Repository navigation
Add searchByMemo full-text search to search.ts #614
Description
Description
src/search.ts searches invoices by fields like status and recipient but has no memo-content search. Payment memo text is a common way users tag invoices (e.g. "split:INV-001") and cannot currently be searched across a local invoice array.
Acceptance Criteria
-
searchByMemo(invoices: Invoice[], query: string, opts?: { caseSensitive?: boolean }): Invoice[]exported fromsrc/search.ts - Returns invoices where
invoice.memocontainsqueryas a substring; case-insensitive by default - Empty
queryreturns all invoices unchanged - Invoices with
memoofundefinedornullare skipped without error -
opts.caseSensitive = trueenables exact-case matching - Exported from
src/index.ts - Unit tests: substring match, case-insensitive default, case-sensitive override, empty query returns all, null memo skipped
Context
- Target files:
src/search.ts,src/index.ts Invoice.memois a string field insrc/types.ts— may be optional
Activity
bobo-24 commentedon Aug 19, 2026
Hi! I’m a full-stack developer with a strong blockchain background, and I’m confident I can resolve this issue quickly and effectively. I’ll deliver a clean, reliable solution with immediate attention to detail, ensuring it’s completed as soon as possible. Please assign it to me—I’m ready to get started right away.
bobo-24 commentedon Aug 19, 2026
Hi! I’m a full-stack developer with a strong blockchain background, and I’m confident I can resolve this issue quickly and effectively. I’ll deliver a clean, reliable solution with immediate attention to detail, ensuring it’s completed as soon as possible. Please assign it to me—I’m ready to get started right away.
feat(search): add searchByMemo for memo-content lookup (Stellar-split…
fix(index): export searchByMemo and SearchByMemoOptions (Stellar-spli…
Solis666 commentedon Sep 6, 2026
Hi Kingsman-99. This PR is ready and conflict-free with main (mergeable): it's an atomic change isolated strictly to #614 (
searchByMemoinsearch.ts, exported fromindex.ts, tests P1–P10). The diff against main touches only the 3 files of the issue. Is there any additional test or CI check I should run to get it ready for merge? Happy to address any feedback.ranjeet150 commentedon Sep 15, 2026
Hi everyone,
I would like to resolve this issue. Here is my proposed execution plan:
Add searchByMemo full-text search to search.tsaddressing all stated requirements.Ready to deliver a clean, tested PR within 12–24 hours. Please assign!
Solis666 commentedon Sep 16, 2026
Hi Kingsman-99,
Following your guidance on the closed PR #817, I’d like to formally request assignment of issue #614 to @Solis666 before opening another PR.
I understand the concern about avoiding duplicate work and will not submit a new PR until the issue is assigned. I already have an implementation prepared from the previous attempt, covering the acceptance criteria and tests, and I’m happy to update it based on any feedback you have.
If you’re comfortable with it, please assign #614 to @Solis666 and I’ll proceed from there. Thank you!
feat(search): add searchByMemo for invoice memos (Stellar-split#614)
aigon-x commentedon Oct 13, 2026
I'd like to work on this. I have opened #1026 implementing
searchByMemo()per the acceptance criteria (case-insensitive default,caseSensitiveoverride, empty query returns all, null/undefined memo skipped, exported fromsrc/index.ts), with unit tests intest/searchByMemo.test.ts(7/7 passing).Happy to be assigned — please let me know if any change to the approach is preferred.