docs: note drawImage keeps only the most recent scaled size per path - #45
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (Copilot reviewer could not be added:
Judgment call noted: the README bullet grows longer; a wording split was considered and rejected to keep one bullet per method, matching the No blocking findings. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage A documentation accuracy sweep (README,
pyproject.toml,RELEASING.md, and in-code docstrings checked against source).drawImage's scaled-surface cache holds only the most recent(size, surface)pair per path (self._scaledImages[filePath] = (size, scaledImage)), which is already pinned bytest_draw_image_rescales_when_size_changes. The docstring and the README described the scaled surface as simply "cached", so a consumer drawing one asset at two alternating sizes per frame would not expect a rescale on every call.drawImagedocstring and the README method list now state that behavior. No code or behavior was changed.No tracking issue — gap found during triage.
Deferred issues
.github/workflows/and the release process; left for a maintainer decision.test.ymlheader comment) — workflow files are excluded from autonomous change.preponderous/__init__.pynamespace package) — its prerequisite (the convention used by siblingpreponderous.*projects) cannot be settled from this repository.Test plan
python3 -m py_compile src/main/python/preponderous/graphik/graphik.pypython3 -m pytest— 53 passed (headless viaconftest.py)This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson