Repository navigation
security(ci): reject VS Code tasks with automatic folderOpen execution - #578
Open
umpireboulianne-design wants to merge 1 commit into
Open
umpireboulianne-design wants to merge 1 commit into
umpireboulianne-design wants to merge 1 commit into
Conversation
Collaborator
|
I reviewed the diff and did not find a malicious payload, but this branch now conflicts with current main after related changes landed. Please rebase on current main, preserve the already-merged security and CI gates, rerun the relevant tests, and update this PR; it is not safe to merge the stale conflict state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #477
Adds
scripts/check-vscode-tasks.mjsandscripts/check-vscode-tasks.test.mjsto scan.vscode/tasks.jsonfiles for automatic"runOn": "folderOpen"triggers without executing or printing task commands, wires the check intocoverage:testandvscode-tasks:check, and documents local usage.Verification
node scripts/check-vscode-tasks.mjsnode --test scripts/check-vscode-tasks.test.mjs