Repository navigation
ci: enforce committed snapshot and dashboard evidence health (#521) - #602
Open
huangji6693-max wants to merge 1 commit into
Open
huangji6693-max wants to merge 1 commit into
huangji6693-max wants to merge 1 commit into
Conversation
Collaborator
|
I reviewed the diff and did not find a malicious payload, but this branch now conflicts with current main after related changes landed. Please rebase on current main, preserve the already-merged security and CI gates, rerun the relevant tests, and update this PR; it is not safe to merge the stale conflict state. |
huangji6693-max
force-pushed
the
ci/enforce-committed-snapshot-health-521
branch
from
October 27, 2026 15:53
918260e to
61b5c32
Compare
Author
|
Thanks for the review @karagozemin! Rebased cleanly onto current |
huangji6693-max
force-pushed
the
ci/enforce-committed-snapshot-health-521
branch
from
October 27, 2026 16:05
61b5c32 to
b5946b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-snapshots.mjs(pnpm snapshot:check) so that in addition to checking all 51 required contract snapshot categories undercontracts/round/test_snapshots/test, it validates that:.jsoncontract snapshot parses as a valid Soroban snapshot object (generators,auth,ledger,events).apps/web/src/demo/demo-trace.generated.tsandapps/web/src/demo/demo-trace.checksum.ts) is present, matchesLIFE_CYCLE_PHASES_CHECKSUM, includes all required lifecycle milestones (create_round,commit,open_reveal,reveal_all,settle), has matching bidder/agent/settlement/auditor evidence blobs, and contains no Stellar secret seeds.scripts/check-snapshots.test.mjs(pnpm snapshot:test) covering healthy repo snapshots, missing directories, missing snapshot categories, corrupted snapshot JSON payloads, stale dashboard milestone phases/checksums, and CI workflow enforcement..github/workflows/snapshots.ymland wirecheck-snapshots.mjs+check-snapshots.test.mjsinto.github/workflows/contract.yml.docs/CI.mdandREADME.md.Supply-chain review
"snapshot:test": "node --test scripts/check-snapshots.test.mjs"to rootpackage.jsonto run the snapshot health unit tests; no dependencies changed..vscode/, workflow, or other editor/config file changes. If changed, list them below..github/workflows/snapshots.ymland two steps in.github/workflows/contract.ymlto runsnapshot:testandsnapshot:checkin CI.preinstall/postinstall) was added.Testing
node --test scripts/check-snapshots.test.mjs(7/7 tests passing)node scripts/check-snapshots.mjs(51/51 required categories + 119 snapshot JSON payloads + dashboard evidence healthy)node scripts/check-line-lengths.mjs&node --test scripts/check-line-lengths.test.mjsCloses #521