Repository navigation
Say what led up to an error in the debug report - #559
Merged
Merged
Conversation
A report now opens with the build, platform, language and session (signed in or not, local or cloud strategy, window size), keeps where Flutter says an error happened, and lists the recent steps before it: focus moving between fields, the window going to the background, canvas edits, undo/redo, strategy and page switches, and every message between text fields and the system's text input, with lengths instead of text. The copied report is fenced as a code block so Discord and Markdown show it as written.
A widget's key follows its name in Flutter's error context, and a placed text's key is its text; Flutter's longer description can quote text on screen. Keep the context up to the key and leave the description out.
Watching the strategy from the start of main made it before the cloud was set up, and it reads the session as soon as it exists, so startup failed on Supabase not being initialized. It now starts after the first frame and can only cost the trail its strategy steps. Focus can also move to a field before it is laid out; the focus step says so instead of asking it for a position it doesn't have yet.
From a real report on Windows 11: call it Windows 11 (Windows names itself 10 to programs), say whether the build is debug or release and which cloud it talks to, give the report's time zone, put the steps before an error's stack instead of after hundreds of frames, keep 60 steps and leave out show, hide and autofill messages, which crowded them out, and name a field by its hint when it has one.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the whole of a report a Windows user sent today (pasted through Discord, which turned
:34:into an emoji):No version, no OS, nothing about what they were doing. We couldn't tell which text field it was or reproduce it.
After, copied from a debug build of this branch (720ca19) on Windows 11, excerpt:
The last commit, made from reading this report, changes the header to say
Windows 11 Home(Windows calls itself 10 to programs), the build mode (build 111, debug), which cloud (Cloud: development, started), and the UTC offset afterGenerated.That trace already shows something worth a look: when the canvas text box loses focus after 40 typed characters, the app sends Windows an empty editing state just before letting go of the field. That's the kind of ordering the user's error is about. Following it up is separate work.
What a report now carries
The text input trace is a binding whose messenger passes every platform message through unchanged and notes the text input ones (
lib/services/text_input_trace.dart). It returns the original reply future and the original handler result, so callers see the same timing.Nothing typed reaches the trail: tests type into fields and check the text never appears. Repeats collapse to one line with a count, so 40 keystrokes are one line.
How far this got
flutter testpasses in full (3,799 tests).Not covered: an IME (Japanese or Chinese input), and the report from a signed-in cloud session.
ci: analyze test web