Skip to content

Put Haven's spawn barriers where VALORANT has them - #560

Merged
SunkenInTime merged 1 commit into
mainfrom
t3/fix-haven-spawn-barrier
Nov 13, 2026
Merged

SunkenInTime merged 1 commit into
mainfrom
t3/fix-haven-spawn-barrier

Conversation

@SunkenInTime

@SunkenInTime SunkenInTime commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Editor, attack side, before and after

A player (THINKII, Discord, Nov 13) reported that one of Haven's spawn barriers is drawn in the wrong place. It stood upright on a wall beside the corridor it should close. This PR puts it across the corridor, and fixes the other Haven barriers that were off.

Before. assets/maps/haven_spawn_walls.svg was drawn by hand in 94858c5 and never changed. One file serves both sides: the editor, the saved screenshot and the replay viewer draw it over the map and turn it 180° on defense.

Now. All nine bars are placed from the game's own data: the nine SpawnBarrier_C actors in Triad_Gameplay.umap (13.09 game files), each one's position, facing and width, taken through the same game-to-map transform the view cones use.

Game data over the old barriers

Cyan is where VALORANT has each barrier, the bars are what Icarus drew.

  • The reported barrier moves 9 units right and 7 down and turns to lie across the corridor.
  • The long attacker barrier beside it moves 8 units up (about 2.3 m), and the defender barrier on the far right moves 10 up (about 2.8 m). Both sat past their opening.
  • One defender barrier moves 3 units left. The other five were within 2.5 units and move onto the game's line.
  • Each bar is as wide as the game's barrier. Where that stops up to 2.3 units short of the drawn wall (the art is not exact to the game), the end runs on to the wall so the bar closes the opening as drawn. Five ends, listed below.
  • The file's frame is now 393 x 473, the map art's frame. It was 393 x 474, which drew every bar 0.2% small against the map.

Art only. Barriers are not items, so nothing saved changes and nothing a user placed moves.

Seen in a running build. Windows release driver build of main, same exe for both runs, only this file swapped. tool/drive/scripts/haven-spawn-barriers.json (new) turns the barriers on, shoots both sides and saves a screenshot. Both runs finished clean.

Defense side:

Editor, defense side, before and after

Saved screenshot:

Saved screenshot, before and after

Not checked. The replay viewer: there is no Haven replay on the PC. It loads the same file with the same turn for defense. Web was not run either, it is the same asset.

For the Figma source. Drop-in file: haven_spawn_walls.svg. Frame 393 x 473, every bar 4 thick, no rotation. Numbers follow the file's order:

Numbered barriers

# Side Old x, y, size as drawn Old rotation in the file New x New y New w New h Change
1 attack 71, 323, 4 x 18 none 71.08 324.16 4 14.11 under 1 unit, shortened to the opening
2 attack 149, 335, 20 x 4 -90 150.31 332.78 17.06 4 2.2 up. Left end runs on 1.75, right end 1.5
3 defense 185, 222, 19 x 4 -90 186.93 224.03 14.35 4 2 down
4 defense 114, 233, 45 x 4 -90 116.28 235.43 40.57 4 2.4 down. Right end runs on 1
5 defense 26, 240, 23 x 4 -90 27.7 241.57 19.12 4 1.6 down. Left end runs on 1.38
6 defense 316, 216, 4 x 19 none 313.15 218.83 4 14.26 2.9 left
7 defense 357, 248, 24 x 4 -90 358.89 238.06 17.71 4 9.9 up
8 attack 211, 308, 4 x 18 none 214.73 322.37 15.64 4 the reported one: now across the corridor. Ends run on 1.5 and 2.25
9 attack 230, 339, 46 x 4 -90 232.4 331.03 39.52 4 8 up

Old positions are the box each bar covered on screen. In the old file the rotated ones are stored as 4 wide and N tall at (x, y + 4), turned -90 about that point, which Figma shows as 90.

ci: skip

Summary by CodeRabbit

  • Chores
    • Added an automated workflow that captures screenshots of the Barriers view, including map layers, attack and defense screens, and the export result. No user-facing changes are included.

One attacker barrier stood upright on a wall instead of lying across its
corridor, and two more sat about 3 m from their openings. All nine are now
placed from the SpawnBarrier actors in the game files (13.09), ends run
on to the drawn walls. The frame is 393 x 473 to match the map art.

tool/drive/scripts/haven-spawn-barriers.json shows them in the editor on
both sides and in a saved screenshot.
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

This change adds an automation script that captures the barriers settings, attack, and defense views. It also opens the export dialog and waits for the exported PNG.

Changes: Barriers view captures

Layer / File(s) Summary
View capture and export sequence
tool/drive/scripts/haven-spawn-barriers.json
The script captures settings and attack screenshots, scrolls the attack view, opens the export dialog, and waits up to 30 seconds for a PNG. It then captures the post-export state, switches to defense, captures screenshots around a scroll, and exits with code 1.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 29830

This change adds a developer automation script for capturing Haven barrier views. It has no effect on production behavior, saved items, or user data, and it carries no merge-blocking risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states that Haven's spawn barriers are being moved to match VALORANT's barrier positions. The raw summary and PR objectives confirm the change repositions all nine barrier bars using the Spa…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states that Haven's spawn barriers are being moved to match VALORANT's barrier positions. The raw summary and PR objectives confirm the change repositions all nine barrier bars using the SpawnBarrier_C actor positions from game files. The title names the main change, so it passes. The title is 50 characters and 8 words, which meets the short, single-sentence requirement.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: da2d4d76-9cec-4ffd-a928-19cd1b967ce9
Commits

Reviewing files that changed from the base of the PR and between e88d112 and 2983076.

Files ignored due to path filters: 1

  • assets/maps/haven_spawn_walls.svg is excluded by !**/*.svg
Files selected for processing: 1

  • tool/drive/scripts/haven-spawn-barriers.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@SunkenInTime
SunkenInTime merged commit 24b99f2 into main Nov 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant