Skip to content

Wait for desktop hover and RPC state in Windows checks #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sc-frederick merged 1 commit into from
Nov 5, 2026
Merged

Wait for desktop hover and RPC state in Windows checks #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/packet.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ test("document QA needs no count check and persisted findings support evidence,
.filter({ hasText: /^Elapsed/ });

await expect(lockTiming).toHaveAttribute("data-tip", /Local edits are paused until then/);
await page.mouse.move(0, 0);
await lockTiming.hover();
await expect(page.getByTestId("review-tooltip")).toBeVisible();
await expect(page.getByTestId("review-tooltip")).toContainText("Local edits are paused");
Expand Down
4 changes: 3 additions & 1 deletion tests/e2e/project-navigation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ test("replayed reviews and a progress burst share bounded snapshot refreshes", a
const panel = page.getByTestId("packet-review-panel");
await expect(panel).toContainText("Alpha saved review 12");
await expect(page.locator(".previous-reviews > div")).toHaveCount(11);
expect(await page.evaluate(() => window.rpcControl.held())).toEqual(["ReviewSnapshot"]);
await expect
.poll(() => page.evaluate(() => window.rpcControl.held()))
.toEqual(["ReviewSnapshot"]);
// The selection's snapshot plus one refresh for the whole replay.
expect((await snapshotProjects(page)).slice(before)).toEqual([
alpha.project.id,
Expand Down
Loading