Repository navigation
Fix/ops 49 50 58 - #144
Merged
Merged
Fix/ops 49 50 58#144
Conversation
Argument parsing, with_database, and manifest parsing in the shell scripts had no bats coverage.
db-rollback.sh always deleted only the newest journal row, so reverting several migrations took a separate run for each one.
Every pod could reach every other pod. Only ingress-nginx should reach the apps, and the backend only needs DNS, the database, and RPC.
|
@DevMusa001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db-rollback.shrevert more than one migration per run via--steps.Closes Add bats tests for the shell scripts #49
Closes db-rollback.sh: support rolling back more than one migration #50
Closes Add NetworkPolicies #58