Skip to content

wiki: a realm's last member can leave it to their heir - #307

Merged
XxFran10xX merged 1 commit into
mainfrom
docs/wiki-will-heir-realms
Oct 24, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
docs/wiki-will-heir-realms

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Summary

Updates "Wills and inheritance" on /wiki/characters for SimpleFactions 4.15.0 (TF-Minecraft/SimpleFactions#206).

The page said "Leading a guild or realm never passes by will." That is no longer true for a character who was the last member of their realm. Their heir now becomes its leader 24 hours after the death, if the heir is alive and in no other faction, and an heir who is still in another faction has a week from the death to leave it.

4.15.0 is released and staged routine on Main (and Tutorial), so it goes live at Main's next restart. The config key, staff holds on estates and the revive edge cases stay off the page.

Checks

  • oxfmt --check and oxlint on the changed file: clean.
  • vitest run app/wiki: 139 passed, 1 skipped.
  • The production build is left to CI (the local Windows build hits the known PageScroll filename case clash).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58f021fb-d62a-4c6c-8a17-b08bd770da70
Commits

Reviewing files that changed from the base of the PR and between 3582be6 and 2ffe65b.

Files selected for processing: 1
  • frontend/app/wiki/characters/page.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that guild or realm leadership may pass by will if the deceased was the last member of their realm. The heir becomes realm leader 24 hours after the death if they are alive and belong to no other faction.
    • Heirs who belong to another faction have one week from the death to leave it.

The Characters page updates its wills and inheritance guidance. It adds an exception for realm leadership when the deceased was the last member of their realm.

Changes: Inheritance guidance

Layer / File(s) Summary
Realm leadership exception
frontend/app/wiki/characters/page.tsx
The guidance states that an eligible heir becomes realm leader 24 hours after the deceased’s death. If the heir is in another faction, they have one week from the death to leave it.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: ryanbarlow97

Merge Risk: Minimal · up to 2ffe6

This documentation-only update is mergeable with no actionable risk remaining.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX
XxFran10xX merged commit d34354a into main Oct 24, 2026
8 checks passed
@XxFran10xX
XxFran10xX deleted the docs/wiki-will-heir-realms branch October 24, 2026 21:31

This branch was successfully deployed

1 active deployment
preview — 2ffe65b2 Deployed Oct 24, 2026 by XxFran10xX via deploy #845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant