Repository navigation
feat: per-vehicle icons in menus and on tickets - #83
Merged
Merged
Conversation
Vehicles may set an optional icon section (material plus optional model_data) after model. When set, the skin menu shows every skin as the icon with a glint and "Current skin" on the active one, the seat menu shows the vehicle in slot 24, the repair menu uses it for the hull, the ownership menu shows it in slot 18, and minted tickets take its item model and custom model data. Vehicles without an icon keep the old menus. The skin click now finds the current skin by its id instead of by yellow concrete. The default vehicles use the new coal icons 7400-7421. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vehicles can name an icon in their config, and VehicleFramework shows it wherever it shows a vehicle:
A vehicle without
icon:, or with an unknown material, keeps today's menus and tickets exactly.Testing
mvn -B clean verify: 1770 tests pass. Locally the coverage gate reports 10 missed lines in persistence/loader code that the POSIX-permission tests (skipped on Windows) cover;mainfails the same way here, so CI decides. No new or changed line is uncovered.item_model minecraft:coal+ CMD 7403. The pack overlays (items/coal.json) map 7400-7421 afteriazip.🤖 Generated with Claude Code