Skip to content

feat: tangent - resource management via document entity - #2733

Open
maxy-shpfy wants to merge 1 commit into
09-17-feat_tangent_-_interactive_chips_in_tangent_chatfrom
09-17-feat_tangent_-_resource_management_via_document_entity
Open

maxy-shpfy wants to merge 1 commit into
09-17-feat_tangent_-_interactive_chips_in_tangent_chatfrom
09-17-feat_tangent_-_resource_management_via_document_entity

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds support for attaching pipeline runs as resources in Tangent projects, alongside the existing pipeline attachment capability.

A new AddPipelineRunDialog allows users to browse and select a pipeline run from the RunSection, which required adding an onRunClick callback prop to both RunRow and RunSection to intercept row clicks without navigating away.

Resource metadata (type, workarea identity, URL) is now stored in a structured extraData field on project resources rather than relying on entity/entityId fields. A new resourceExtraData.ts module handles serialization and parsing of this data for both local_pipeline and pipeline_run resource types.

The "Add a pipeline" button in ResourcesWindowContent has been replaced with a split AddResourceButton that exposes both "Add a pipeline" and "Add pipeline run" options via a dropdown. The resources panel layout has also been redesigned: the collapsible ContentBlock sections are replaced with a flat list of ResourceRow items, each showing an icon, title, and description. Instructions are now rendered as a ResourceRow as well.

Screenshots (if applicable)

Screen Recording 2026-09-18 at 12.38.10 PM.mov (uploaded via Graphite)

Test Instructions

  1. Open a Tangent project and navigate to the Resources panel.
  2. Click "Add a pipeline" and verify a pipeline can be attached as before.
  3. Open the dropdown chevron next to "Add a pipeline" and select "Add pipeline run".
  4. Select a run from the list and confirm it appears in the resources panel with a Play icon and "Pipeline run" description.
  5. Click an attached pipeline run resource and verify it opens correctly in the workarea.
  6. Remove an attached resource and confirm it is deleted.
  7. Verify the Instructions row renders correctly with and without existing instructions.

Additional Comments

The extraData field on project resources must be supported by the API. The payload: {} field is included as a required placeholder per the existing API contract.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 09-17-feat_tangent_-_resource_management_via_document_entity/ff8a2a5

maxy-shpfy commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_interactive_chips_in_tangent_chat branch from 40b4c48 to fd9ed3e Compare September 18, 2026 18:52
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_resource_management_via_document_entity branch from 332ab5a to e222f69 Compare September 18, 2026 18:52
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_interactive_chips_in_tangent_chat branch from fd9ed3e to ac2652f Compare September 18, 2026 19:13
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_resource_management_via_document_entity branch from e222f69 to 27fbce5 Compare September 18, 2026 19:13
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_interactive_chips_in_tangent_chat branch from ac2652f to 9fff15f Compare September 18, 2026 19:18
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_resource_management_via_document_entity branch from 27fbce5 to 0397e5a Compare September 18, 2026 19:18
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_interactive_chips_in_tangent_chat branch from 9fff15f to 17aba5f Compare September 18, 2026 19:28
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_resource_management_via_document_entity branch from 0397e5a to 04f6c04 Compare September 18, 2026 19:28
@maxy-shpfy
maxy-shpfy force-pushed the 09-17-feat_tangent_-_resource_management_via_document_entity branch from 04f6c04 to ff8a2a5 Compare September 18, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant