Skip to content

feat(kubernetes): retry Job Pods lost to infrastructure disruptions #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuechao-qin wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

feat(kubernetes): retry Job Pods lost to infrastructure disruptions #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions cloud_pipelines_backend/launchers/kubernetes_launchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,25 @@ def launch_container_task(
max_failed_indexes=0,
completions=num_nodes,
parallelism=num_nodes,
# Retry infrastructure disruptions only:
# DisruptionTarget -> Ignore -> not charged -> replacement Pod
# anything else -> charged -> budget is 0 -> index fails
# Kubernetes sets DisruptionTarget for preemption, eviction, taint-based
# deletion, node loss and graceful node shutdown -- never for a task's
# own exit code.
pod_failure_policy=k8s_client_lib.V1PodFailurePolicy(
rules=[
k8s_client_lib.V1PodFailurePolicyRule(
action="Ignore",
on_pod_conditions=[
k8s_client_lib.V1PodFailurePolicyOnPodConditionsPattern(
type="DisruptionTarget",
status="True",
)
],
)
]
),
),
)

Expand Down
Loading