Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lib/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import { type HostPermissionSnapshot } from "./host-permissions"
import { compressPermission, syncCompressPermissionState } from "./compress-permission"
import { checkSession, ensureSessionInitialized, saveSessionState, syncToolCache } from "./state"
import { cacheSystemPromptTokens } from "./ui/utils"
import { getModelInfo } from "./messages/inject/utils"

const INTERNAL_AGENT_SIGNATURES = [
"You are a title generator",
Expand Down Expand Up @@ -104,6 +105,23 @@ export function createSystemPromptHandler(
}
}

// Messages are transformed before the system prompt hook reports the model limit,
// so the first request of a fresh process would otherwise see no limit and nudge.
async function lookupModelContextLimit(
client: any,
messages: WithParts[],
): Promise<number | undefined> {
const { providerId, modelId } = getModelInfo(messages)
if (!providerId || !modelId) return undefined
try {
const response = await client.config.providers()
const provider = response?.data?.providers?.find((p: any) => p.id === providerId)
return provider?.models?.[modelId]?.limit?.context || undefined
} catch {
return undefined
}
}

export function createChatMessageTransformHandler(
client: any,
state: SessionState,
Expand All @@ -124,6 +142,10 @@ export function createChatMessageTransformHandler(

await checkSession(client, state, logger, output.messages, config.manualMode.enabled)

if (state.modelContextLimit === undefined) {
state.modelContextLimit = await lookupModelContextLimit(client, output.messages)
}

syncCompressPermissionState(state, config, hostPermissions, output.messages)

if (state.isSubAgent && !config.experimental.allowSubAgents) {
Expand Down
48 changes: 48 additions & 0 deletions tests/hooks-permission.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -807,3 +807,51 @@ test("manual mode persisted setting refreshes server session state", async () =>
await refreshManualMode(state, sessionId, logger, true)
assert.equal(state.manualMode, false)
})

test("chat message transform resolves a percentage threshold before the system prompt hook runs", async () => {
const state = createSessionState()
const config = buildConfig("allow")
config.compress.minContextLimit = "55%"
config.compress.maxContextLimit = "80%"
const handler = createChatMessageTransformHandler(
{
session: { get: async () => ({}) },
config: {
providers: async () => ({
data: {
providers: [
{
id: "anthropic",
models: { "claude-x": { limit: { context: 200000 } } },
},
],
},
}),
},
} as any,
state,
new Logger(false),
config,
buildPromptStore(),
{ global: undefined, agents: {} },
)
const user = (id: string) => {
const message = buildMessage(id, "user", "short question")
;(message.info as any).model = { providerID: "anthropic", modelID: "claude-x" }
return message
}

await handler(
{},
{
messages: [
user("user-1"),
buildMessage("assistant-1", "assistant", "short answer"),
user("user-2"),
],
},
)

assert.equal(state.modelContextLimit, 200000)
assert.equal(state.nudges.turnNudgeAnchors.size, 0)
})