Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #650 (the failed-summary part; the concurrent-session part is not covered)
findLastCompactionTimestampnow only counts an assistant summary that finished without an error, the same check OpenCode uses. A failed compaction no longer resets and saves an empty DCP state.Tested: unit tests (V1 failed summary, V2 history compaction). Sandbox on OpenCode 1.19.5: a failed summary mid-session keeps the blocks (before: state wiped, 14.9K → 43.2K), and a real /compact still resets. Sandbox on OpenCode 2.3.0: /compact still logs "Detected compaction" and IDs restart at @1@.