Skip to content

🔒 [security fix directory traversal in tar unpack] - #250

Merged
github-actions[bot] merged 1 commit into
mainfrom
security-fix-tar-unpack-2200096652374879433
Oct 7, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
security-fix-tar-unpack-2200096652374879433

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Fixed a directory traversal vulnerability in the untar_archive function within stdlib/src/compress.rs.
⚠️ Risk: The previous implementation used the top-level Archive::unpack method, which could potentially allow extraction of files outside the intended destination directory (e.g., via absolute paths or .. traversals in filenames) if not properly protected, leading to arbitrary file overwrite vulnerabilities.
🛡️ Solution: Modified the extraction logic to iterate over the archive entries and call Entry::unpack_in explicitly on each one, enforcing the built-in directory traversal protections. Included cleanup of temporary testing files to ensure repository hygiene.


PR created automatically by Jules for task 2200096652374879433 started by @Tcode-Motion

Iterate over tar archive entries and call `unpack_in` on each entry instead
of using the top-level `Archive::unpack` method, ensuring proper directory
traversal protections are applied.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 7, 2026 13:10
@github-actions
github-actions Bot merged commit 059c7f4 into main Oct 7, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant