Repository navigation
🔒 Fix Directory Traversal in untar_archive - #256
Conversation
…ck_in on entries Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The
⚠️ Risk: An attacker could provide a maliciously crafted tar archive with absolute paths or parent directory traversals (
untar_archivefunction usedtar::Archive::unpackinstead of iterating and usingtar::Entry::unpack_in, which bypassed the built-in directory traversal protections.../) to escape the intended extraction directory, potentially overwriting sensitive files on the host system.🛡️ Solution: Replaced
unpackwith an iteration over archive entries, utilizingunpack_infor each entry to ensure paths are securely restricted to the destination directory during extraction.PR created automatically by Jules for task 8975660819707095155 started by @Tcode-Motion