Skip to content

🔒 [Security] Fix command injection in PowerShell notification #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tcode-Motion wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🔒 [Security] Fix command injection in PowerShell notification #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bbc2d
Fix command injection in PowerShell notification
google-labs-jules[bot] Oct 7, 2026
f7bf8ac
Fix command injection in PowerShell notification
google-labs-jules[bot] Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions stdlib/src/notification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,24 @@ impl StdlibRegistry {
#[cfg(target_os = "windows")]
{
use std::process::Command;
use base64::Engine;
let b64_title = base64::prelude::BASE64_STANDARD.encode(title.as_bytes());
let b64_body = base64::prelude::BASE64_STANDARD.encode(body.as_bytes());
let script_text = format!(
"[System.Windows.MessageBox]::Show(\
[System.Text.Encoding]::UTF8.GetString([System.Convert]::FromBase64String('{}')), \
[System.Text.Encoding]::UTF8.GetString([System.Convert]::FromBase64String('{}'))\
)",
b64_body, b64_title
);
let mut script_utf16: Vec<u8> = Vec::with_capacity(script_text.len() * 2);
for c in script_text.encode_utf16() {
script_utf16.push((c & 0xFF) as u8);
script_utf16.push((c >> 8) as u8);
}
let encoded_cmd = base64::prelude::BASE64_STANDARD.encode(&script_utf16);
let _ = Command::new("powershell")
.env("TS_NOTIFY_TITLE", &title)
.env("TS_NOTIFY_BODY", &body)
.args([
"-Command",
"[System.Windows.MessageBox]::Show($env:TS_NOTIFY_BODY, $env:TS_NOTIFY_TITLE)"
])
.args(["-NoProfile", "-EncodedCommand", &encoded_cmd])
.spawn();
}
#[cfg(not(target_os = "windows"))]
Expand Down
8 changes: 6 additions & 2 deletions stdlib/tests/stdlib_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,9 @@ fn test_http_module() {
&mut ctx_unprivileged,
vec![RuntimeValue::Str(format!("http://127.0.0.1:{}", port))],
);
assert!(matches!(res_get, Err(techscript_runtime::RuntimeError { kind: techscript_runtime::RuntimeErrorKind::InvalidOperation(msg), .. }) if msg.contains("Security policy violation")));
assert!(
matches!(res_get, Err(techscript_runtime::RuntimeError { kind: techscript_runtime::RuntimeErrorKind::InvalidOperation(msg), .. }) if msg.contains("Security policy violation"))
);

let post = http.exports.get("post").unwrap();
let res_post = post.call(
Expand All @@ -550,7 +552,9 @@ fn test_http_module() {
RuntimeValue::Str("body".to_string()),
],
);
assert!(matches!(res_post, Err(techscript_runtime::RuntimeError { kind: techscript_runtime::RuntimeErrorKind::InvalidOperation(msg), .. }) if msg.contains("Security policy violation")));
assert!(
matches!(res_post, Err(techscript_runtime::RuntimeError { kind: techscript_runtime::RuntimeErrorKind::InvalidOperation(msg), .. }) if msg.contains("Security policy violation"))
);

// Test with Network capability
let mut caps = HashSet::new();
Expand Down