Repository navigation
Conversation
ch-z-hc
marked this pull request as ready for review
October 14, 2026 08:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network capture discards request metadata at
Network.responseReceived, but that event only means headers arrived. If the response body subsequently fails, theNetwork.loadingFailedentry loses its URL, method and resource type. This makes truncated downloads and interrupted fetches harder to diagnose withbsk network.Keep the existing bounded metadata until
loadingFinishedorloadingFailed. Response entries are still recorded immediately; tab isolation and detach cleanup are unchanged. The regression now checks attribution after a response and verifies cleanup after successful loading.Verified with an isolated headless Chrome profile and a local HTTP server that sends HTTP 200 and an incomplete body: Chrome emits
responseReceived, thenloadingFailedwithnet::ERR_CONTENT_LENGTH_MISMATCHfor the same request. The updated attribution test fails on unchanged source and passes with this patch.Validation on Windows / Node 24.14.0 / pnpm 10.17.0:
pnpm lintis not fully green: its DSH suite has 492 passed and 2 failed intests/runner.test.ts. Both failures reproduce in an unmodified4c8616bworktree under the same environment. No assertions, timeouts or skip conditions were relaxed. Rust tests and the full opt-in browser matrix were not run.Codex assisted with investigation, implementation and testing. This has not had an independent human code review.