Repository navigation
Fix Levenshtein distance for empty strings - #301
Merged
siriak merged 1 commit intoNov 18, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Sourcing the file interactively still triggers prompts and overwrites variables, while empty-string inputs unnecessarily allocate and fill a large matrix.
2 open issues
What changed in this PR
Updates the repository’s R Levenshtein-distance implementation to handle empty strings correctly and improve input and example handling.
Changes:
- Uses
seq_len()and skips distance-table updates when either input is empty. - Adds single-value input validation and character coercion.
- Gates the example with
interactive()and removes invisible characters from the output code.
| File | Description |
|---|---|
string_manipulation/levenshtein.r |
Fixes empty-string iteration, validates inputs, and updates the interactive example and output formatting. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes an edge-case error in
levenshtein_distance()when one or both input strings are empty.The original implementation used loops such as
1:n. Whennwas zero, R evaluated this as1:0, causing invalid matrix indexing.This change:
seq_len()for safe iteration.Tests
Verified the following cases: