Repository navigation
fix: cancel host countdown after leaving quiz - #236
Merged
TheCodeHeist-Coder merged 1 commit intoNov 17, 2026
Merged
TheCodeHeist-Coder merged 1 commit into
TheCodeHeist-Coder merged 1 commit into
Conversation
Contributor
Author
|
The current head |
TheCodeHeist-Coder
self-requested a review
November 17, 2026 05:28
TheCodeHeist-Coder
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Capture the host's three-second
quiz:startcountdown timer, cancel it when the live quiz screen unmounts, and send the first question only while the original socket is still open. A repeated start message replaces the previous timer instead of scheduling duplicate sends.Related issue
Closes #178
Type of change
Which services does this touch?
apps/frontendHow did you test this?
pnpm --filter frontend test -- src/screens/LiveQuiz.test.tsx: 9 tests passed, including host departure during countdown and a closed socket.pnpm --filter frontend check-types: passed.pnpm --filter frontend build: passed.git diff --check: passed.LiveQuiz.tsxon unchanged lines; this PR adds no new lint findings. I did not run a multi-participant browser session or Docker Compose.Checklist
pnpm run lint(existing lint findings noted above)pnpm run check-typespnpm run build(frontend)docker-compose up(not run).envfile, API key or other secret.