Repository navigation
Refuse to start a quiz that has no questions - #238
Merged
TheCodeHeist-Coder merged 1 commit intoNov 18, 2026
Merged
TheCodeHeist-Coder merged 1 commit into
TheCodeHeist-Coder merged 1 commit into
Conversation
TheCodeHeist-Coder
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #162.
Server side: quiz:start now checks the cached questions first. With none, it sends an error with code NO_QUESTIONS and leaves the session in WAITING, so the room never reaches the empty GET READY and COMPLETED path.
Frontend: the lobby shows that error message under the Start Game button. The button itself is not disabled up front, because the lobby still has no question count. That would need the count added to the session payload, so I left it for a follow-up.
Tests: added a case to handleMessages.auth.test.ts and made the default mock return one question. ws-server vitest passes (56). I did not typecheck or run the frontend change.