Repository navigation
fix(auth): select offered TOTP methods when configured - #619
Open
Disaster-Terminator wants to merge 2 commits into
Open
Disaster-Terminator wants to merge 2 commits into
Disaster-Terminator wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sign-in method picker offers an authenticator code, accounts with a configured
totpSecretstill select push approval. Existing TOTP classifications were ignored by the picker, and the current phone/desktop SVG was classified asUNKNOWN.Recognize that code tile and select an offered TOTP method when a secret is configured, including methods matched by the existing
phone_app_otp/totprules. Configured password precedence is preserved, and selection continues through the existing2FA_TOTPhandler.Local validation:
SIGN_IN_METHOD_PICKER → 2FA_TOTP → handlerwith the configured secret. The same suite fails classification and selection against unmodified upstreamv4.Run after installing the locked dependencies and Patchright Chromium:
The SVG match follows the existing structural classifier and may need updating when Microsoft changes the icon. The fix applies to code verification offered in the visible method picker.
Related: #520 addressed a similar unattended-TOTP problem in the v3 passwordless flow. This fixes the v4 method picker directly.