Skip to content

chore(license): Add SPDX-License-Identifier to LICENSE.md - #3290

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
tintinhamans:arctic/chore/spdx-license
Sep 14, 2026
Merged

chore(license): Add SPDX-License-Identifier to LICENSE.md#3290
xezon merged 1 commit into
TheSuperHackers:mainfrom
tintinhamans:arctic/chore/spdx-license

Conversation

@tintinhamans

@tintinhamans tintinhamans commented Sep 13, 2026

Copy link
Copy Markdown

Adds SPDX-License-Identifier: GPL-3.0-or-later as the first line of LICENSE.md so GitHub (and other third-party) license detectors can recognize the license.

It was previously not auto-detected because of the additional EA terms appended after the standard GPLv3 text.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-13T20:45:03.791395Z 4f3451c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Add SPDX identifier to GPLv3 license

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Adds the GPL-3.0-only SPDX identifier to the license file.
• Enables automated license detection despite the appended Electronic Arts terms.
High-Level Assessment

The SPDX identifier is the standard, minimal solution for improving automated license detection without modifying the existing GPLv3 text or additional terms.

Files changed (1) +2 / -0

Documentation (1) +2 / -0
LICENSE.mdDeclare the GPL-3.0-only SPDX license identifier +2/-0

Declare the GPL-3.0-only SPDX license identifier

• Adds an SPDX license identifier at the beginning of the file so GitHub and other tools can recognize the repository license despite the appended terms.

LICENSE.md

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the SPDX header in LICENSE.md from GPL-3.0-only to GPL-3.0-or-later.

  • Leaves the previously reported incomplete representation of EA’s additional Section 7 terms unresolved.
  • Also labels the GPL component as “or later,” although the license notice describes GPL version 3 without granting the later-version option.

Confidence Score: 4/5

The PR is not safe to merge until the SPDX declaration accurately represents both the GPL grant and EA’s additional terms.

The previous blocking finding remains outstanding. The new identifier still omits EA’s additional Section 7 terms, and changing the GPL component to GPL-3.0-or-later introduces a later-version grant that the document’s GPL version 3 notice does not state.

Files Needing Attention: LICENSE.md

Important Files Changed

Filename Overview
LICENSE.md Changes the SPDX identifier to GPL-3.0-or-later, but the existing licensing finding remains unresolved.

Reviews (2): Last reviewed commit: "chore(license): add SPDX-License-Identif..." | Re-trigger Greptile

Comment thread LICENSE.md Outdated
@tintinhamans
tintinhamans force-pushed the arctic/chore/spdx-license branch from 4f3451c to 34fbd4e Compare September 13, 2026 20:59
@xezon xezon changed the title chore(license): add SPDX-License-Identifier to LICENSE.md chore(license): Add SPDX-License-Identifier to LICENSE.md Sep 14, 2026
@xezon xezon added the Documentation Is documentation or complementary resource label Sep 14, 2026

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@xezon

xezon commented Sep 14, 2026

Copy link
Copy Markdown

@Stubbjax Probably also can be done in Patch2 repo.

@xezon
xezon merged commit ebb78fa into TheSuperHackers:main Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Is documentation or complementary resource

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants