Skip to content

Spec drift: regenerate models - #28

Closed
tpw-drift[bot] wants to merge 1 commit into
mainfrom
bot/spec-drift
Closed

tpw-drift[bot] wants to merge 1 commit into
mainfrom
bot/spec-drift

Conversation

@tpw-drift

@tpw-drift tpw-drift Bot commented Sep 27, 2026

Copy link
Copy Markdown

Automated regeneration from https://api.themeparks.wiki/docs/v1.yaml

  • regenerate: success
  • live smoke tests: success

A regenerate failure means the upstream contract changed in a way
this client cannot absorb automatically. Do not merge until green.

@cubehouse

Copy link
Copy Markdown
Member

#29 contains these exact models — git diff between the two branches on themeparks/_generated/models.py is empty — plus the code that uses the fields they add.

Worth recording why this one mattered more than a usual regeneration. Pydantic drops fields the model does not declare, so while these models were stale the SDK was deleting unknownMinutes, inParkHours and extremeWaits at parse time for every caller of days(), not just leaving them untyped. A stale schema in a Python client loses data; in the TypeScript client it only loses types.

Safe to close once #29 goes in.

@cubehouse

Copy link
Copy Markdown
Member

Superseded by #29, which is merged and carries these exact models. The nightly job will open a fresh one if the spec moves again.

@cubehouse cubehouse closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant