Repository navigation
feat(commits): validate fixed review head and parent reads - #633
Conversation
Preserve unknown root and ordered parent context through a fixed-head detail read without substituting mutable branch references or exposing obsolete captured-account results. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
left a comment
There was a problem hiding this comment.
Reviewed commit f237a5d: Exact fixed-head route/identity, immutable ordered nullable parents, malformed/self/duplicate parent rejection, status-first sanitized decoding and redirect options are correct. Captured read-only authentication and originalCommit currency guards preserve current typed failures and discard obsolete results. Existing branch/tag detail compatibility remains covered. All six PR blobs match the reviewed local commit. Full format/analyze and 7,770 local tests pass, including 72 new test-first/compatibility cases. No blocking findings. No parent choice, original references/coordinates, MR membership or private-write eligibility is inferred; guarded integration and UI remain follow-ups.
Summary
Add a strict fixed-commit detail read that confirms the exact requested SHA and validates ordered nullable parent metadata before exposing it to future original review context. Add captured-account repository currency guards that discard obsolete results and typed failures. Existing general branch/tag detail reads retain their contract.
Closes #632
Validation
dart format .flutter analyzereports no warningsflutter testin all five packagesChecklist
dev, links one issue, Conventional Commit and DCO sign-offNotes for reviewers
The strict API requires a full lowercase SHA-1 and exact returned identity; reported parents must be canonical, distinct and not self-referential. Absent/null remains unknown; empty means reported root; server order is preserved. It requests stats=false, checks status before plain JSON parsing and disables redirects while retaining captured read-only OAuth recovery. OriginalCommit reads through one captured account/target; caller rechecks currency after await. No parent selection, blank/empty-tree reference synthesis, membership proof, original coordinate or private-write/UI eligibility follows. Those checks and guarded review UI remain follow-ups; MW-07/image/file drafts remain in progress. See
docs/fixed-commit-review-reads.md.