Skip to content

feat(merge_requests): reconfirm original commit context - #635

Merged
sjungwon03 merged 1 commit into
devfrom
feat/634-original-mr-commit-context
Oct 11, 2026
Merged

sjungwon03 merged 1 commit into
devfrom
feat/634-original-mr-commit-context

Conversation

@sjungwon03

Copy link
Copy Markdown
Member

Summary

Combine strict original MR commit reads through one captured account. Fetch target commit detail and literal diff only after selected membership is confirmed, then reconfirm MR origin and membership before returning. Changed origins/membership and contradictory known parents fail; obsolete results and typed errors are discarded. Unknown source/parent metadata and literal omission flags remain intact.

Closes #634

Validation

  • dart format .: 969 files; zero outstanding changes.
  • flutter analyze: no issues.
  • All five package suites: 7,821 tests.
  • 51 new adapter-based tests fail against the unimplemented reader and pass after implementation.
  • Generated files: not applicable; named record aggregate of existing DTOs.
  • Device validation: not applicable to this repository-only slice; no live GitLab validation claimed.

Checklist

  • Targets dev; linked issue; Conventional Commit and DCO sign-off.
  • Test-first behavior and updated contract/parity documentation.
  • English repository prose; dummy test credentials only.
  • Layout/themes, dependencies and localization: unchanged.

Notes for reviewers

Sequential reads are not an atomic snapshot or write-safety proof. Original parent/reference selection, complete literal hunk/coordinate validation and guarded controller/private-save reservation/recovery UI remain follow-ups. Captured guards do not cancel dispatched reads or authentication recovery.

Combine captured target reads with fresh MR identity and membership checks while preserving unknown parent metadata and discarding obsolete outcomes.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@sjungwon03
sjungwon03 marked this pull request as ready for review October 11, 2026 04:23
@github-actions github-actions Bot added area:ui Screens and feature UI area:docs AGENTS.md, .agents/, README and friends feat New feature labels Oct 11, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit 06608e0: All four PR blobs match the reviewed local commit. One captured client performs target-project fixed commit and literal diff reads only after membership validation, then refreshes MR identity/origin and exhausts membership again. Unknown parent/source metadata remains unknown; both-known ordered parents must agree. All six phases discard obsolete success and typed failures; current failures remain typed. Full format/analyze and 7,821 local tests pass, including 51 new test-first cases. No blocking findings. Sequential reads are not atomic, and original refs/coordinates or private-write eligibility are not inferred; guarded literal selection and controller/private-save UI remain follow-ups.

@sjungwon03
sjungwon03 merged commit c909237 into dev Oct 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs AGENTS.md, .agents/, README and friends area:ui Screens and feature UI feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine and reconfirm captured original MR commit context

2 participants