Repository navigation
feat(merge_requests): reconfirm original commit context - #635
Conversation
Combine captured target reads with fresh MR identity and membership checks while preserving unknown parent metadata and discarding obsolete outcomes. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
left a comment
There was a problem hiding this comment.
Reviewed commit 06608e0: All four PR blobs match the reviewed local commit. One captured client performs target-project fixed commit and literal diff reads only after membership validation, then refreshes MR identity/origin and exhausts membership again. Unknown parent/source metadata remains unknown; both-known ordered parents must agree. All six phases discard obsolete success and typed failures; current failures remain typed. Full format/analyze and 7,821 local tests pass, including 51 new test-first cases. No blocking findings. Sequential reads are not atomic, and original refs/coordinates or private-write eligibility are not inferred; guarded literal selection and controller/private-save UI remain follow-ups.
Summary
Combine strict original MR commit reads through one captured account. Fetch target commit detail and literal diff only after selected membership is confirmed, then reconfirm MR origin and membership before returning. Changed origins/membership and contradictory known parents fail; obsolete results and typed errors are discarded. Unknown source/parent metadata and literal omission flags remain intact.
Closes #634
Validation
dart format .: 969 files; zero outstanding changes.flutter analyze: no issues.Checklist
dev; linked issue; Conventional Commit and DCO sign-off.Notes for reviewers
Sequential reads are not an atomic snapshot or write-safety proof. Original parent/reference selection, complete literal hunk/coordinate validation and guarded controller/private-save reservation/recovery UI remain follow-ups. Captured guards do not cancel dispatched reads or authentication recovery.