Repository navigation
Description
Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.
Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: a116d3a6c4904312a16a0b576d59e7d0
Branch: dev/1-approval-note-i18n
Base: fc198e3
Bot: FlyBot Dev-1
Tier: T3 (plugins/social/src/**)
The approval card is translated now, but the note the host posts into the chat is still two English constants: WAITING_OTHERS = "Waiting for the owner's approval" and REJECT_NOTE = 'Rejected.' (plugins/social/src/hidden-remotes.js:125, :126). A Chinese window therefore reads a Chinese card and, right above it, an English system line.
Where (live main cf00e675)
| constant | defined | posted |
|---|---|---|
WAITING_OTHERS |
plugins/social/src/hidden-remotes.js:125 |
plugins/social/src/social.js:3554 — await postChatNote(item, WAITING_OTHERS, { chats: false }) |
REJECT_NOTE |
plugins/social/src/hidden-remotes.js:126 |
plugins/social/src/social.js:3564 — await postChatNote(item, REJECT_NOTE) |
Both go through postChatNote, so the text is written into the chat history as given; nothing on the host path calls t(). plugins/social/src/** is T3 by .github/agent/risk-rules.json, and no client dictionary entry can reach this path — it is not a plugins/social/client.js draw site.
Reproduction
- In a Chinese window, hold an outgoing Bot Social message so an Approve card appears (any kind other than
face_room_message/ owner 1:1 — those two are skipped at:3552/:3553on purpose,#140/#179). - The card is Chinese; the note posted next to it reads
Waiting for the owner's approval. - Reject the held item: the follow-up note reads
Rejected..
Expected
The note follows the same language decision the card already makes, so a Chinese window shows Chinese for both notes (and an English window keeps today's text).
Scope
plugins/social/src/hidden-remotes.js+plugins/social/src/social.js(host note text), plus a test that asserts the posted text for both notes.- Working out how the host knows which language to use is part of the change (the chat/window language, not the sender's) — say it in the PR body, do not hard-code Chinese.
core/src/host/hooks.js— one line only: expose the host's existingrt.uiLanguage()(core/src/host/channel.js:41; fed by the browserstaterequest'slocale,Englishwhen there is no window) to plugins asuiLanguage, so the plugin can pick the note text on the host path. Hooks has no language field today (onlywatched).core/src/host/hooks.jsis not inpolicy/gates.jsongateFiles(checked livemain, 14 entries,2026-11-17T00:55Z), so the tier stays T3 fromplugins/social/src/**.- Not in scope: the four card controls (
#3032, client side) and the#140/#179decisions about whether a note is posted. - Not in scope: anything under
core/src/client/**,core/client.jsorpatches/ds-bot/0008. Translating on the browser side was considered and rejected on 2026-11-17 (A over B): it would put a second PR on the single bundle lane while#3126is in flight there, and the issue's target is the note text the host writes, not a client draw site.
Duplicate check (2026-11-16, live main cf00e675)
grep -n "WAITING_OTHERS\|REJECT_NOTE" on main → defined at hidden-remotes.js:124-126, posted only at social.js:3554/:3564. Searched open+closed issues: "Waiting for the owner's approval" → #1118 (a shared group stalls), #1607 / #1638 (client card stuck with no buttons or a poll behind) all closed and all client-side; postChatNote → #123, #278, #371 closed, none about the note's language; #3006 / #3012 / #3032 cover the cards' draws only. No issue covers these two notes' text.
Activity
HugoXK commentedon Nov 16, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: a116d3a6c4904312a16a0b576d59e7d0
At: 2026-11-16T12:44:55Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: a116d3a6c4904312a16a0b576d59e7d0
At: 2026-11-17T00:47:08Z
HugoXK commentedon Nov 17, 2026
Owner change on our side: Dev-1 takes this now (FlyBot Dev-3 is on #3126 until it gets its verdict). Same claim
a116d3a6c4904312a16a0b576d59e7d0, branch isdev/1-approval-note-i18noff livemainfc198e33e89121fbcfab472cde66773207306660.Written-by: FlyBot Lead
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: a116d3a6c4904312a16a0b576d59e7d0
At: 2026-11-17T02:28:43Z