Skip to content

social: host-posted room notices are still hardcoded English in a zh window (join/leave/lead/started, Not sent, No call) #3133

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: afa41cd69518472387b89fdc114745d6
Branch: dev/1-face-notices-zh
Base: 8f01c23
At: 2026-11-17T01:50:36Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Bot: FlyBot Dev-1

Dedupe (checked before opening, live main 8f01c231a46a): grep finds exactly one call site per signature string — was not ready to talk with you yet → plugins/social/src/social.js:2497 (plus prose in docs/subsystems/social.md), joined; available to this room only → plugins/social/src/face-rooms.js:434 (plus three test fixtures); no open or closed issue covers these host-side room notices — the closed zh issues (#2973, #2999, #3090, #3098, #3100) are all browser-draw sites in plugins/social/client.js (the rejected B lane).

What happens

With the window in Chinese, the host still writes English into the owner's chats and face rooms. Same class as #3124 (fixed by #3131). Audit method: grep over postChatNote/postNotice/rooms.postNotice/remote.chats.deliver/deliver(/notice( in core/src + plugins/*/src, every call site classified by hand (log repo/tmp/bench-3124-audit.md). Six real sites, all in plugins/social:

  1. plugins/social/src/social.js:2497 — flybot.remote.chats.deliver writes into the owner's own chat: Not sent: ${friendBotTitle(handle)} was not ready to talk with you yet, so it did not get your message. Send it again. (a message.not_delivered line; the comment at :2484 self-documents it landing in that chat). Same shape as social: the approval card is translated but the host still posts "Waiting for the owner's approval" and "Rejected." as English notes #3124's approval notes — the strongest.
  2. plugins/social/src/social.js:4607 — rooms.postNotice: No call went out for ${…}: this connector token may not attest typed lines, so the other home reads this line as a Bot's.
  3. plugins/social/src/face-rooms.js:434-435 — platformJoinText: ${who} joined / ${who} joined; available to this room only, posted via social.js:4238 (postNotice) and :4269-4270 (applyFaceLine + postNotice).
  4. plugins/social/src/face-rooms.js:440-441 — platformLeaveText: ${who} left the room / ${who} left. Implementation trap: face-rooms.js:449-451 leaveNoticeCoveredByClose anchors these with the English regex /^(.+) left(?: the room)?$/; translating the copy must move the matcher with it, or a leave notice double-posts as a close notice.
  5. plugins/social/src/face-rooms.js:460-463 — platformLeadText: Room lead: ${…} / The room lead left. The default lead takes over. / The room lead is back to the default.
  6. plugins/social/src/face-rooms.js:465-467 — platformStartedText: The room is now open. The number is no longer valid. / Joining has ended. The room is now open. …

Weak suspects deliberately not counted (model-facing prompts a user may read in passing: turns.js retry/rate-limit texts, groups.js report frame, secrets.js savedNote, task-drive.js Continue-task cue) — out of scope; owner may decide separately.

Expected

  • zh window (zh, zh-*): every one of these notices reads Chinese.
  • English window, any other locale, and no window: byte-identical to today.
  • leaveNoticeCoveredByClose still recognizes the localized leave notice (covered by a test both ways).

Scope

  • plugins/social/src/face-rooms.js + plugins/social/src/social.js: route the six sites through the locale seam Translate the approval notes with the window's language #3131 adds (noteLanguage() / flybot.uiLanguage()), Chinese copy beside the constants; the leave regex moves with its copy.
  • New zh test under plugins/social/test/ driving the real host path (call('state', { locale: 'zh-CN' }), as Translate the approval notes with the window's language #3131's test does) — red first on live main for all six, plus the English negative control.
  • docs/subsystems/social.md (arch-docs) and one changelog.d/ fragment.
  • Out of scope: browser-draw copy in plugins/social/client.js / core/client.js (the rejected B lane), the weak suspects above, anything in core/src.

Sequencing

This edits the same file as #3131 (social.js) and reuses its seam, so it waits behind #3131: cut from live main after #3131 merges, re-run the red/green pair on that base, one push. Do not touch #3131's branch or its tip.

Tier: T3 (plugins/social/src/**).

Activity

  1. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: afa41cd69518472387b89fdc114745d6
    At: 2026-11-17T02:28:51Z

  2. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: afa41cd69518472387b89fdc114745d6
    At: 2026-11-17T03:29:32Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions