Skip to content

social: approve-all failure notice joins each person's reasons instead of running them together #3140

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: c6e193304a9f4dcebf80e4371b203790
Branch: dev/1-social-failed-join
Base: 16915af
At: 2026-11-17T05:30:33Z

缺陷

「Approve all」批量审批的失败提示把每个人的失败原因拼成一句,读不出是谁、哪条卡失败:同一人两张卡都失败时整句重复一遍;两人失败时第二个人的名字粘在前一句的尾部。

红先(改动前的两条 not ok 实际串,逐字照抄,不是改写)

  • 同一人两张卡都失败 → 实际 "Eve: the hold is stale Eve: the hold is stale";期望 "Eve: the hold is stale"
  • Eve / Bob 各不同失败 → 实际 "Eve: the hold is stale Bob: Bot Social is unreachable";期望 "Eve: the hold is stale · Bob: Bot Social is unreachable"

期望

失败提示按人头归组:同名同理由只留一条,同名不同理由 , 并列,条目之间用 · 分隔;decide() 与卡上 reason 一字不动。

范围

只动 approveAll 的汇总层:failed 数组 → Map(name → reasons[]);plugins/social/client.js(+11/−3)、plugins/social/test/approve-all-failure.test.js(新增两条用例,+44/−2)、docs/subsystems/social.md(+1/−1)。T2,分支 dev/1-social-failed-join,base 16915af98。

验证

红先两条在 base 上 not ok;改后同文件 5/5(含 #3093 原三条不回归),plugins/social 全套 710/710;core lint / arch-docs(提交后树)/ lint-plugins / build-client / patches 全过,其余 11 步逐条全绿,core 套件唯一红是既知环境项 bench.sh … mkdir: not found。

查重:#3071/#3072(mixed Approve all 抹掉失败原因,均 closed)与 #3093(失败卡保留原因为)已落;本条是同一条提示串按人头归组,未被覆盖。

Activity

  1. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: c6e193304a9f4dcebf80e4371b203790
    At: 2026-11-17T07:02:25Z

  2. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: c6e193304a9f4dcebf80e4371b203790
    At: 2026-11-17T08:45:22Z

  3. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: c6e193304a9f4dcebf80e4371b203790
    At: 2026-11-18T00:12:54Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions