Skip to content

read_own_chat part read: a checkpointed current part says 'only its newest messages' and never says how many of them it hid #3144

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 002116f654c34193a6e12cd374aced47
Branch: dev/1-own-chat-checkpoint-count
Base: e9513f1
At: 2026-11-17T07:56:35Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Bot: FlyBot Dev-1

Category: defect — a capped read that never says what it left out makes a dropped message read as gone. #1906 set that rule for the bare read_own_chat read (it prints newest 12 of 15 today); #2774 fixed the sentence for a checkpointed current part but not the count: the answer says "only its newest messages are still in your context" while showing 12 of the part's 15 messages, so the three it dropped read as if they never existed.

Red first — measured on e9513f10b, new case a condensed current part says how many of its messages it still shows in core/test/group-work.test.js:

not ok - the read hid three messages without saying so: Part 1 is the current one, but its earlier messages are condensed into [Checkpoint 1], so only its newest messages are still in your context:
[part 1 #3 · 01-01 00:00] User: message 3 in one part

The part holds 15 messages, 12 are shown, and the sentence carries no count.

Expected: the same sentence uses the count the handler already computes (more):

  • more > 0 → Part 1 is the current one, but its earlier messages are condensed into [Checkpoint 1], so only its newest 12 of 15 messages are still in your context:
  • more === 0 → … so only its newest 3 messages are still in your context: (no total when nothing is hidden)

Everything else stays byte-identical: the data layer, the index, the ended-part handoff branch and the no-checkpoint branch.

Where (live main = e9513f10bf7b3280c4d0b1228a278855d3a5b0b0): core/src/host/groups.js, the part read's checkpoint branch (the more value is already computed there for the shown lines), plus core/test/group-work.test.js.

Slice (XS, one file + its test): use more in that one sentence. No new state field, no part N semantics change, no client change, no wording change to the ended-part or the no-checkpoint branch.

Mirror: groups.js is mirrored by patches/ds-bot/0001-core-fixes.patch and patches/ds-bot/0012-room-membership.patch; node scripts/ds-bot-patches.mjs generate rewrites exactly those two (+27/−4), after which check reports 10 patches apply cleanly in order / core/ equals ds-bot/ + patches/ds-bot/ and canonical reports generate is a no-op. Those two files are generated artifacts, not hand edits, and the PR body says so.

Sequence (Lead): patches/ds-bot/0001-core-fixes.patch is also touched by the in-flight replay PR #3143. This branch therefore waits for #3143 to land and then regenerates on the new main, so the PR does not ship a guaranteed conflict.

Dedupe (2026-11-17, two steps). 1) Ledger and notes: no entry for this count. 2) GitHub: read_own_chat condensed checkpoint newest of messages count → 8 results, all closed — #2774/#2776 (the sentence fix this one completes), #1906 (the bare-read count), #2891/#2896 (test pins), #2780/#2838/#2855 (room reads), #3037 (group read); checkpoint current part earlier messages condensed count more → 2 results, both closed (#2774, #2896). No open duplicate.

Risk tier: T2 — core/src/host/** is not listed in any rule of .github/agent/risk-rules.json, so unknownPathTier: T2 applies and the PR needs the reviewer's PASS at its tip.

Activity

  1. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 002116f654c34193a6e12cd374aced47
    At: 2026-11-17T08:44:37Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions