Repository navigation
fix(workflow): name the feature 工作流 in every Chinese sentence - #3130
Conversation
|
@Birfy review request — tip c98ab92 (T2) PR #3130, What changed. The Chinese Workflows page named the feature two ways on one screen: the header, a row's badge (#3102/#3105) and the missing-plugin hint already said 工作流, while sixteen right-hand values of the plugin's own zh dictionary still printed the English word inside Chinese copy — empty state, new/rename/delete buttons, their error toasts, the Tier. T2 — Checks at this tip (18): 15 success + 2 skipped + 0 cancelled + 1 failure. The only failure is Red first / green after. Baseline source: 534 pass / 4 fail, twice. Fixed: 538 / 0, twice. At the tip Written-by: FlyBot Dev-5 (posted by FlyBot Lead) |
|
@Birfy review request — tip c98ab92 (T2) — first delivery PR #3130,
Written-by: FlyBot Lead |
|
Verdict: PASS at c98ab92 Ran at this tip: Review points.
|
|
Ready for queue — tip c98ab92 (T2) PR #3130, Checks at this tip: 18 success + 2 skipped + 0 cancelled + 0 failure — Written-by: FlyBot Lead |
Fixes #3129
Written-by: Dev-5
Owner: Dev-5
Bot: Dev-5
Reviewer: Reviewer
Tier: T2 —
plugins/workflow/client.jsmatchesplugins/**in.github/agent/risk-rules.json, so this needs a PASS at the tip.What changed
The Chinese Workflows page named the feature two ways on one screen: the page header, a row's badge (#3102) and the missing-plugin hint already said 工作流, while sixteen right-hand values of the plugin's own dictionary still printed the English word inside Chinese copy — the empty state, the new, rename and delete buttons, their error toasts, the
Workflow 图settings tab,正在读取 Workflow…,此 Workflow 持有的任务, the reading hint and the created toast.All sixteen now say 工作流 (
还没有工作流。,新建工作流,工作流图,正在读取工作流…,工作流「{name}」已创建 · 成员 {members}, …). The English keys and the English copy are untouched,Workflow: '工作流'was already right, and no i18n baseline moved because no key changed. The workflow subsystem page states the rule, so the next change to this page keeps one name.Two server-side Chinese stored fallbacks still spell it
Workflow(src/service.jsfor the created line,src/narrate.jsfor a run start). They are the text kept for rows written before the key existed, a zh window renders those rows through the dictionary, and they are outside this issue's sixteen values — left for a separate change rather than widening this diff.Verification at the tip
Tip SHA: c98ab92
Tree: 62f835f438b64fa1529f1c17f6e860fb0fdfe21e
Base:
8f01c231(the head on the fork is the same five blobs rebuilt on that tree by the push helper; parent, tree and message are identical, the committer stamp differs).Ran (twice,
TZ=UTC, fromplugins/workflow):node --import ./test/resolve.mjs --test "test/*.test.js"— red first on the base copy with the new expectations: 534 pass / 4 fail, all four about the English word left in a Chinese sentence (the host-translation test, the new#3129table test, and the two timeline-locale renders); after the fix 538 pass / 0 fail.Ran:
TZ=UTC npm run verifyat the tip — exit 0, nine suites# fail 0(core 3271, social 701, tree 149, timeline 172, workflow 538, project 147, gate+policy 685, 37, 34);arch-docs: OK (5 changed file(s)).Not run (and why): no smoke test — client copy only, no
index.jsorsrc/host/change. Nocore/client.jsand nopatches/ds-bot/0008change: the plugin source ships as-is on the single-carrier lane.Checkpoint
{ "pr": 3130, "claim": "Dev-5", "issue": 3129, "summary": "The Chinese Workflows page named the feature two ways: the page header and row badge said 工作流, while sixteen values of the plugin's dictionary still printed the English word inside Chinese copy. Those sixteen now say 工作流 — empty state, buttons, error toasts, graphs tab, reading hint and created toast — with the English keys and copy unchanged. A new test reads the copy through the translation helper, the path a zh window takes, and the timeline-locale assertions that render the same table follow it. The workflow subsystem page states the rule.", "files": [ "plugins/workflow/client.js", "plugins/workflow/test/client.test.js", "plugins/workflow/test/timeline-locale.test.js", "docs/subsystems/workflow.md", "changelog.d/3129.fixed.md" ], "checks": { "ran": "TZ=UTC npm run verify; node --import ./test/resolve.mjs --test \"test/*.test.js\" in plugins/workflow, twice", "result": "green", "at": "c98ab92c92fb2d1b173610729e0c1337ae8976ff" }, "next": "none — ready for review" }