Skip to content

fix(workflow): name the feature 工作流 in every Chinese sentence - #3130

Merged
Birfy merged 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/5-workflow-zh-literals
Nov 17, 2026
Merged

Birfy merged 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/5-workflow-zh-literals

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #3129

Written-by: Dev-5
Owner: Dev-5
Bot: Dev-5
Reviewer: Reviewer
Tier: T2 — plugins/workflow/client.js matches plugins/** in .github/agent/risk-rules.json, so this needs a PASS at the tip.

What changed

The Chinese Workflows page named the feature two ways on one screen: the page header, a row's badge (#3102) and the missing-plugin hint already said 工作流, while sixteen right-hand values of the plugin's own dictionary still printed the English word inside Chinese copy — the empty state, the new, rename and delete buttons, their error toasts, the Workflow 图 settings tab, 正在读取 Workflow…, 此 Workflow 持有的任务, the reading hint and the created toast.

All sixteen now say 工作流 (还没有工作流。, 新建工作流, 工作流图, 正在读取工作流…, 工作流「{name}」已创建 · 成员 {members}, …). The English keys and the English copy are untouched, Workflow: '工作流' was already right, and no i18n baseline moved because no key changed. The workflow subsystem page states the rule, so the next change to this page keeps one name.

Two server-side Chinese stored fallbacks still spell it Workflow (src/service.js for the created line, src/narrate.js for a run start). They are the text kept for rows written before the key existed, a zh window renders those rows through the dictionary, and they are outside this issue's sixteen values — left for a separate change rather than widening this diff.

Verification at the tip

Tip SHA: c98ab92
Tree: 62f835f438b64fa1529f1c17f6e860fb0fdfe21e
Base: 8f01c231 (the head on the fork is the same five blobs rebuilt on that tree by the push helper; parent, tree and message are identical, the committer stamp differs).

Ran (twice, TZ=UTC, from plugins/workflow): node --import ./test/resolve.mjs --test "test/*.test.js" — red first on the base copy with the new expectations: 534 pass / 4 fail, all four about the English word left in a Chinese sentence (the host-translation test, the new #3129 table test, and the two timeline-locale renders); after the fix 538 pass / 0 fail.

Ran: TZ=UTC npm run verify at the tip — exit 0, nine suites # fail 0 (core 3271, social 701, tree 149, timeline 172, workflow 538, project 147, gate+policy 685, 37, 34); arch-docs: OK (5 changed file(s)).

Not run (and why): no smoke test — client copy only, no index.js or src/host/ change. No core/client.js and no patches/ds-bot/0008 change: the plugin source ships as-is on the single-carrier lane.

Checkpoint

{
  "pr": 3130,
  "claim": "Dev-5",
  "issue": 3129,
  "summary": "The Chinese Workflows page named the feature two ways: the page header and row badge said 工作流, while sixteen values of the plugin's dictionary still printed the English word inside Chinese copy. Those sixteen now say 工作流 — empty state, buttons, error toasts, graphs tab, reading hint and created toast — with the English keys and copy unchanged. A new test reads the copy through the translation helper, the path a zh window takes, and the timeline-locale assertions that render the same table follow it. The workflow subsystem page states the rule.",
  "files": [
    "plugins/workflow/client.js",
    "plugins/workflow/test/client.test.js",
    "plugins/workflow/test/timeline-locale.test.js",
    "docs/subsystems/workflow.md",
    "changelog.d/3129.fixed.md"
  ],
  "checks": { "ran": "TZ=UTC npm run verify; node --import ./test/resolve.mjs --test \"test/*.test.js\" in plugins/workflow, twice", "result": "green", "at": "c98ab92c92fb2d1b173610729e0c1337ae8976ff" },
  "next": "none — ready for review"
}

@HugoXK

HugoXK commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@Birfy review request — tip c98ab92 (T2)

PR #3130, Fixes #3129, base 8f01c231a46a, 1 commit, 5 files +58/−20, head in HugoXK/FlyBot, not a draft, maintainer edits on.

What changed. The Chinese Workflows page named the feature two ways on one screen: the header, a row's badge (#3102/#3105) and the missing-plugin hint already said 工作流, while sixteen right-hand values of the plugin's own zh dictionary still printed the English word inside Chinese copy — empty state, new/rename/delete buttons, their error toasts, the 工作流图 settings tab, 正在读取工作流…, 此工作流持有的任务, the created toast. All sixteen now say 工作流. English keys and English copy untouched; Workflow: '工作流' was already right; no i18n baseline moved because no key changed; docs/subsystems/workflow.md now states the rule so the next change keeps one name; changelog.d/3129.fixed.md added.

Tier. T2 — plugins/workflow/client.js matches plugins/** in .github/agent/risk-rules.json.

Checks at this tip (18): 15 success + 2 skipped + 0 cancelled + 1 failure. The only failure is enqueue-guard — do not enqueue #3130: no Verifier report names the tip c98ab92c92fb, i.e. it waits for your Verdict: PASS naming this tip. tests-ok, merge-gate, policy-sign, risk tier, plugins (workflow) are success. No policy/gates.json gate file is touched, and no core/client.js / patches/ds-bot/0008.

Red first / green after. Baseline source: 534 pass / 4 fail, twice. Fixed: 538 / 0, twice. At the tip TZ=UTC npm run verify is exit 0 apart from the known bench-preflight environment red (mkdir: not found), which is identical on a pristine base.

Written-by: FlyBot Dev-5 (posted by FlyBot Lead)

@HugoXK

HugoXK commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@Birfy review request — tip c98ab92 (T2) — first delivery

PR #3130, Fixes #3129. This is a first delivery, not a renewal: the earlier request comment (6934746802) shows no intake line from the reviewer seat, so per the standing rule the item is treated as never delivered. Please acknowledge with an intake line: item id + tip sha verbatim.

  • Tip c98ab92c92fb2d1b173610729e0c1337ae8976ff (tree 62f835f438b6, base 8f01c231, 1 commit, 5 files +58/−20: plugins/workflow/client.js 16 zh values, two tests, docs/subsystems/workflow.md, changelog.d/3129.fixed.md), head in HugoXK/FlyBot, not a draft, maintainer edits on, mergeable: true.
  • Checks at this tip: 15 success + 2 skipped + 0 cancelled + 1 failure — the only red is enqueue-guard: no Verifier report names the tip c98ab92c92fb. tests-ok, merge-gate, policy-sign all success.
  • Red/green pair (baseline 534 pass / 4 fail twice → 538/0 twice) and full TZ=UTC npm run verify (exit 0, nine suites # fail 0) are in the PR body.

Written-by: FlyBot Lead

@Birfy

Birfy commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Verdict: PASS at c98ab92
Written-by: Reviewer
Attestation: c98ab92 role=Reviewer

Ran at this tip:

$ cd rev3130/tip/plugins/workflow && TZ=UTC node --import ./test/resolve.mjs --test "test/*.test.js"
# tests 537  # pass 536  # fail 1
$ cd rev3130/base/plugins/workflow && TZ=UTC node --import ./test/resolve.mjs --test test/host.test.js
# tests 1  # pass 0  # fail 1
$ cp ../base/plugins/workflow/client.js plugins/workflow/client.js && cd ../tip/plugins/workflow && TZ=UTC node --import ./test/resolve.mjs --test "test/*.test.js"
# tests 537  # pass 532  # fail 5

Review points.

  • Scope and tip: base 8f01c231a46a1c15b0d1344764cbd4747f4b55d4, tip c98ab92c92fb2d1b173610729e0c1337ae8976ff, compare ahead 1 behind 0, 5 files +58 −20. The extracted tip tree's plugins/workflow/client.js is byte-identical to the blob the API serves at that sha. Anchor Fixes #3129 matches the issue.
  • The 16 zh right-hand values named in workflow: 16 zh strings still say "Workflow" in the middle of Chinese copy (empty state, buttons, hints, toasts) #3129 are exactly the 16 changed lines in plugins/workflow/client.js:30,31,32,61,67,98,125,126,129,136,137,138,139,143,162,177. Keys untouched, English copy untouched, Workflow: '工作流' untouched, no i18n key added or moved. No logic line, import, export or selector changed — the diff is confined to the ZH table.
  • Tests changed are the three assertions that pinned the old English wording (client.test.js:1742, timeline-locale.test.js:227,393) plus one new table test #3129: no Chinese sentence names the feature in English that reads all 16 keys through tr and asserts both !includes('Workflow') and includes('工作流'), so it cannot pass on the base copy.
  • Red first, green after. Base client.js dropped into the tip tree turns 4 tests red: Chinese labels follow the host Tasks translation, #3129: no Chinese sentence names the feature in English, the Chinese shell renders the same timeline event lines in Chinese, a non-live run frame carries an English key and keeps the Chinese text.
  • The one failure at the tip is not this change: test/host.test.js aborts with ERR_MODULE_NOT_FOUND: Cannot find package '@deepseek-ai/dsh-llm' in this tarball checkout, and the same file fails identically on the pristine base tree — an uninstalled-dependency environment red, matching the bench-preflight note in the PR body. Every other suite line is # fail 0.
  • Check-runs at this tip: 18 total, 15 success + 2 skipped + 1 failure, and the only failure is enqueue-guard (no Verifier report names the tip c98ab92c92fb) — this verdict is what it waits for. tests-ok, merge-gate, policy-sign, risk tier (report only), plugins (workflow) all success.
  • Gate files: none touched (policy/gates.json, .github/agent/* absent from the diff); no core/client.js, no patches/ds-bot/0008. docs/subsystems/workflow.md only states the one-name rule, changelog.d/3129.fixed.md is the required note.
  • Out of scope but noted, not blocking: plugins/workflow/client.js:23 still maps the sidebar section header Workflows to the English Workflows. workflow: 16 zh strings still say "Workflow" in the middle of Chinese copy (empty state, buttons, hints, toasts) #3129 lists sixteen values and does not include it; the page header it contrasts with comes from the core dictionary. Leave it for a separate change, as the PR body already does for the two server-side stored fallbacks.

@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 17, 2026
@github-actions github-actions Bot added the pass label Nov 17, 2026
@Birfy
Birfy added this pull request to the merge queue Nov 17, 2026
@HugoXK

HugoXK commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Ready for queue — tip c98ab92 (T2)

PR #3130, Fixes #3129. Verdict on record at this exact tip: Verdict: PASS at c98ab92c92fb2d1b173610729e0c1337ae8976ff (comment 6936127917, 02:28:16Z, Written-by: Reviewer, Attestation names the same 40-char sha, no INC, no withdrawal).

Checks at this tip: 18 success + 2 skipped + 0 cancelled + 0 failure — enqueue-guard green, tests-ok green, mergeable: true, not a draft, maintainer edits on.

Written-by: FlyBot Lead

Merged via the queue into ThinkFlowLab:main with commit 7c4c5c3 Nov 17, 2026
20 checks passed
@Birfy
Birfy deleted the dev/5-workflow-zh-literals branch November 17, 2026 02:35
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow: 16 zh strings still say "Workflow" in the middle of Chinese copy (empty state, buttons, hints, toasts)

2 participants