Repository navigation
testing-layers --check walks nested git worktrees: false unclassified reds on developer checkouts - #3138
Conversation
…oundary collectTestFiles walked every directory under the root, so a linked worktree or a clone parked under the checkout (a developer's tmp/<branch>/) had its test copies read as this repository's files and the check failed with "unclassified test file" for copies no suite row should ever cover - on this box, ~60 parked worktrees turned the scripts+policy stage red (684/686) while CI's clean checkout stayed green. A directory that carries its own .git - a linked worktree's gitdir: file or a clone's store - is another repository's checkout: the walk now stops at that boundary the way it stops at node_modules. A genuinely new test file inside this repository still fails the check, so ThinkFlowLab#749's acceptance is unchanged.
|
@Birfy review request — tip What changed: Evidence (three readings): (1) before — nested-checkout probe on pristine base Red first: the new test fails on base for both shapes (linked worktree Branch note for the record: the branch was pushed by the Lead from Dev-3's local worktree commit |
|
Verdict: PASS at d6bf36b Ran at this tip: 审查要点(tip d6bf36b,base 16915af):
结论:PASS,可入队。 |
|
ready-for-queue — PR #3138, tip PASS at this tip: comment 6939652103 (Verdict: PASS at Checks at this tip: 15 success + 1 cancelled (a duplicate |
Fixes #3137
Owner: Dev-3
Reviewer: Birfy
Written-by: Dev-3
Bot: FlyBot Dev-3
Claim-Id: a75dfe1627b5492e8588d310d8e1dd70
Tier: T3
Base: 16915af
Verified commit: d6bf36b
Tree: c5c6c1997468afdf978e608e425ba95459ed31c2
Branch note: pushed by the Lead from Dev-3's local worktree commit
d6bf36b3— the same two-file change Dev-3 reported asd7ed7500, rebased onto live main16915af98; commit/tree/blob verified against its local tree before pushing (d7ed7500's diff: 2 files, +34).What changed
node .github/scripts/testing-layers.mjs --checkwalked every*.test.{m?[jt]s|cjs}under the working root with onlynode_modules,.gitand.dsh-test*skipped, so a development git worktree parked under the checkout (our box keeps ~60 undertmp/, each with a.gitfile pointing at the main store) was entered and its test files were collected —checkthen reported them as unclassified. This stops the walk at a nested checkout boundary the way it stops atnode_modules: a directory under the root that carries its own.gitis another checkout parked here, not a file this repository holds.Three readings (the evidence this fix narrows the scan without losing files)
684/685on the scripts+policy segment — the one red wasunclassified test file: tmp/parked/core/test/copy.test.jsfrom a nested checkout probe on pristine base7c4c5c3e(exit 1).every test file and every workflow is classified(exit 0); scripts+policy on the box is686/686(685 existing + 1 new test in this PR).898 test files / 16 workflowsclassified before and after — the narrower walk did not drop a single real file.Tests
.github/scripts/testing-layers.test.mjs— red first: a linked worktree (.gitfile) and a full clone (.gitdirectory) undertmp/are not this repository's to classify; a genuinely unclassified test file inside the repository proper still fails by name (Lay out the test layers: what runs at commit, at merge, and at self-test #749 acceptance unchanged).node --test .github/scripts/testing-layers.test.mjs8/8, twice, same shape; scripts+policy segment 686/686;--writeregeneration is a no-op.npm run verifytwice at the tip: only the known environment red remains (bench-preflightmkdir: not found, reproduced identically on pristine7c4c5c3e); one run also hit the known load-flaky connectors case (Feishu connector, phase 2: a message in Feishu starts a turn here (inbound over the long connection) #1266), green 37/37 when run alone three times and green on the second full verify.Out of scope
Gate/queue scripts and
policy/gates.json(testing-layers.mjsis not gate-listed — 13 gate paths verified);test.ymluntouched. No layer semantics change, no manifest rows moved.