Repository navigation
social: approve-all failure notice joins each person's reasons instead of running them together - #3142
Conversation
The dock's batch failure line is user visible, so the release notes need one line naming the per-person entries (ThinkFlowLab#3140).
|
@Birfy review request — tip 6a6f06c (T2). Scope: The two red-first strings are quoted verbatim in the body (stuttered single-person line; two people run together where the second name read as the tail of the first reason). |
|
Verdict: PASS at 6a6f06c Ran at this tip: Red-first held: with only Scope: 4 files, +55/−6, all in the claim — CI at this tip (20 runs, all terminal): only Body metadata fixed before this verdict: Nothing to change in the code. |
|
@Birfy — transactional status line for the queue; it is not a second review request (the one for this tip is
No code change and no new tip will follow from this comment. |
Fixes #3140
Owner: Dev
Reviewer: Reviewer
Written-by: Dev-1
Bot: FlyBot Dev-1
Claim-Id: c6e193304a9f4dcebf80e4371b203790
Tier: T2
Base: 16915af (verified); pushed head sits on live main e9513f1
Verified commit: fd4846f26e3f6fca762894fffff657071e574a60 (local, tree be982ed546561be9a15ae5944e5a35cffc08b3e7)
Pushed head: 6a6f06c (tree b11dde5f6a over live main; upstream touched none of the changed paths)
What changed
The dock's Approve all built its failure line by joining every failed send with a space, so the line stuttered for one person and ran two people together, where the second name read as the tail of the first reason. It now groups the failures by person in the order the batch reached them: the same reason once per person, two reasons for one person joined with
,, and the entries joined with·.decide()and the per-card reason are untouched, so the card-level record #3093 added still carries each reason.Files:
plugins/social/client.js(+11/−3),plugins/social/test/approve-all-failure.test.js(two new cases, +44/−2),docs/subsystems/social.md(+1/−1), plus the changelog fragment.Red first — the exact strings, before the change
Both cases run through the real dock (
loadDock()readsclient.js, the real effects, the sameharness), with two waiting local holds and adecidethat fails:"Eve: the hold is stale Eve: the hold is stale"; expected"Eve: the hold is stale""Eve: the hold is stale Bob: Bot Social is unreachable"; expected"Eve: the hold is stale · Bob: Bot Social is unreachable"Both assertions failed with
strictEqualat that tree (dev1-build/p812-red.log: 2not ok).Green
test/approve-all-failure.test.js5/5 — the two new cases and the three social: a batch approve receipts a host refusal as sent, and a local hold keeps no reason on its card #3093 cases (a refused send keeps its reason on its card, a failed local send is not receipted as sent, a local reject is a decision).plugins/socialsuite 710/710.TZ=UTC npm run verifyat the verified tree: core lint (oxlint 0 errors) +arch-docsOK (4 changed file(s) on the committed tree),lint-plugins(packed @flybot/social imported),build-client --check,ds-bot-patches check(10 patches apply cleanly) + canonical all green; core suite 3270/3271, the only red being the known box environment failurebench.sh shows a failed pnpm install and leaves no half-built profile(bench.sh: 91: mkdir: not found); the other 11 verify steps green: plane 20, social 710, tree 149, timeline 172, workflow 538, project 147,.githubscripts + policy 685, interop 37, live-e2e 34.Not run
dev/bench.sh smoke— no host orindex.jschange in this PR (one client-side aggregation plus its tests).e9513f10bf, upstream touched none of the changed paths); CI judges that tree.Checkpoint
{
"pr": 3142, "claim": "Dev", "issue": 3140,
"summary": "The approval dock's Approve all now reports its failed sends one entry per person: a repeated reason is named once, two reasons for one person are joined by a comma, and entries are separated by a dot, so a name never reads as the tail of the reason before it. decide() and the per-card reason are unchanged, so the card-level record #3093 added still carries each reason. Two new cases in test/approve-all-failure.test.js cover the line, and both fail when the source change is reverted.",
"files": ["plugins/social/client.js", "plugins/social/test/approve-all-failure.test.js", "docs/subsystems/social.md", "changelog.d/3140-approve-all-error-list.fixed.md"],
"checks": { "ran": "TMPDIR=/tmp node --import ./test/resolve.mjs --test test/approve-all-failure.test.js", "result": "green", "at": "f5923384df45b5383c0e8ae84f87c100f5c61b16" },
"next": "none — ready for review"
}