Repository navigation
Conversation
A current part whose older messages a checkpoint condensed answered with its newest 12 messages and the words "only its newest messages", so a Bot could not tell that three of fifteen were left out; the bare read has said "newest 12 of 15" since ThinkFlowLab#1906. The sentence now names how many of how many the read shows when the cap hid anything, and stays as before when it shows them all. patches/ds-bot/0001-core-fixes.patch and 0012-room-membership.patch are what `node scripts/ds-bot-patches.mjs generate` writes for this groups.js change; they are generated artifacts, not hand edits. `check` reports 10 patches apply cleanly in order and core/ equals ds-bot/ + patches/ds-bot/; `canonical` reports generate is a no-op; build-client --check is clean (no client change). Docs-not-needed: the changed sentence is the tool's own answer wording; docs/subsystems/core-host.md already states that the cap counts (ThinkFlowLab#1906) and ThinkFlowLab#2774 already documents the checkpoint answer, and neither statement changes.
|
@Birfy review request — tip Read at 08:53:49Z: base Checks at this tip (all 17 completed): 14 success + 0 cancelled + 2 skipped ( What it does: The two A |
|
Self-test advisory at
No defect found; every number in the body reproduces at this tip. |
Fixes #3144
Owner: Dev-1
Reviewer: Birfy
Written-by: Dev-1
Bot: FlyBot Dev-1
Claim-Id: 002116f654c34193a6e12cd374aced47
Tier: T2
Base: 5c46977 (verified live main; pushed head sits on that same commit)
Verified commit: afb16e6eab91410804d9e5fadd466b046df736f6 (local, tree 63ff0608be13ef35f6436058c9e2d195284d6942)
Total: 5 files, +53/−6
What changed
read_own_chaton a current part whose earlier messages a checkpoint condensed answered with the part's newest 12 messages and the words "only its newest messages are still in your context", so a Bot could not tell that three of fifteen were left out — a dropped message read as one that never existed. The handler already computedmorefor the lines it shows; that one sentence now uses it:more > 0→… so only its newest 12 of 15 messages are still in your context:more === 0→… so only its newest 3 messages are still in your context:(no total when nothing is hidden)Nothing else moves: the data layer, the index, the ended-part handoff branch, the no-checkpoint branch and the trailing
Search it with words …line are byte-identical to5c469770.Files:
core/src/host/groups.js(+5/−2),core/test/group-work.test.js(+20, one new case), plus the generated mirrors and the changelog fragment.Red first — measured on this base, exact strings
On
5c469770with only the new test kept (implementation file restored to live main:git checkout 5c469770 -- core/src/host/groups.js),node --import ./test/harness-resolve.mjs --test test/group-work.test.js:The part holds 15 messages, the read shows 12, and the sentence carries no count (
dev1-build/p671-red-on-5c46.log).Green — measured on the verified tree
test/group-work.test.js+own-chat-parts-index+own-chat-read-window+chat-anchors: 36/36.TZ=UTC npm run verify: green, 0not ok— core 3279/3279, plane 20, social 710, tree 149, timeline 172, workflow 538, project 147,.github/scripts+policy686, interop 37, live-e2e 34; core lint (0 errors),lint-plugins,build-client --check,ds-bot-patches check,canonical,lint:interop,lint:live-e2eall pass.pnpmin/usr/bin, whichcore/test/bench-preflight.test.jsstrips from the fixture PATH together withmkdir, so that one case reds here for an environment reason. With a coreutils PATH shim (a workspace dir of symlinks to/usr/bin/*minuspnpm), the same suite is 7/7 and the whole run above is green.ARCH_DOCS_BASE=5c469770014c node core/scripts/check-arch-docs.mjs→arch-docs: OK (5 changed file(s))(run on the committed tree).node .github/scripts/changelog.mjs check→changelog: 7 fragment(s) in changelog.d/ are well formed.Generated vs hand-written (5 files)
node scripts/ds-bot-patches.mjs generate; not hand edits):patches/ds-bot/0001-core-fixes.patchandpatches/ds-bot/0012-room-membership.patch. They are the ds-bot mirror of thegroups.jschange, so the series keeps applying tocore/; nothing here touchespatches/ds-bot/0008-client-bundle.patchorcore/client.js(no client change:build-client --checkis clean).core/src/host/groups.js(the sentence),core/test/group-work.test.js(the new case),changelog.d/3144-own-chat-checkpoint-count.fixed.md.Stale-mirror check (patches truly regenerated, not layered)
grep -c "only its newest messages" patches/ds-bot/0012-room-membership.patch→ 0 (same for0001-core-fixes.patch→ 0), so no old wording survives for a laterapplyto restore.grep -c 'its newest ${lines.length} of ${lines.length + more} messages' patches/ds-bot/0012-room-membership.patch→ 1: the new sentence is in the patch itself.node scripts/ds-bot-patches.mjs check→10 patches apply cleanly in order+core/ equals ds-bot/ + patches/ds-bot/;canonical→patches/ds-bot/ is what generate writes (generate is a no-op).Not run
core/dev/bench.sh smoke— no host runtime orindex.jschange; the diff is one sentence plus its test, mirrors and fragment.build-client --check(nothing undercore/src/client/**orcore/client.jschanged).Docs-not-needed: the changed sentence is the tool's own answer wording;
docs/subsystems/core-host.mdalready states that the cap counts (#1906) and #2774 already documents the checkpoint answer, and neither statement changes.{
"pr": 3146,
"claim": "Dev-1",
"issue": 3144,
"summary": "
read_own_chaton a current part whose earlier messages a checkpoint condensed said "only its newest messages are still in your context" while showing 12 of the part's 15 messages, so the three it left out read as messages that never existed. That sentence now names how many of how many the read shows, and keeps the single number when nothing was hidden. The data layer, the index, the ended-part handoff branch and the no-checkpoint branch are unchanged. The ds-bot mirrors were regenerated rather than hand-edited, so the series still applies tocore/.","files": [
"core/src/host/groups.js",
"core/test/group-work.test.js",
"patches/ds-bot/0012-room-membership.patch",
"changelog.d/3144-own-chat-checkpoint-count.fixed.md"
],
"checks": {
"ran": "TZ=UTC npm run verify; ARCH_DOCS_BASE=5c469770014c node core/scripts/check-arch-docs.mjs; node scripts/ds-bot-patches.mjs check+canonical; node core/scripts/build-client.mjs --check; node .github/scripts/changelog.mjs check",
"result": "green",
"at": "9fe911dbf14ba7839a58d50d07f53f60df2f76b9"
},
"next": "none — ready for review"
}