Skip to content

[bug] nightly: control theme test expects a duration warning at the valid maximum #378

Closed

Description

@hsliuustc0106

Evidence

Extended browser job, step 8 in Nightly 43987891995, main at 729b49bc1d66d0f0e9d8c98c623636463777eaa8, Ubuntu/headless Chromium and Node 24.22.1. control_theme.mjs:310 times out after 15 s waiting for .cw-duration-notice.

Reproduce and diagnosis

Run the existing control_theme.mjs journey with the Nightly extended-browser setup. Open the duration picker and press End on the slider. The test asserts the warning is visible, but End selects the allowed upper bound. The merged duration change #334 made the range warning apply to strictly out-of-range input (seconds < minimum || seconds > maximum), not the valid endpoints.

Expected: The browser test treats End as a valid maximum; if it checks warning styling, it should first enter a genuinely out-of-range value in the number input. Observed: The stale visibility assertion fails despite the valid endpoint. Preserve the intended range behavior; update the test rather than adding wait time or restoring the warning at the maximum. Source and job log agree; I did not independently rerun the browser.

Activity

  1. added a commit that references this issue on Nov 17, 2026
    c3137e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciContinuous integration and checks

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions