Repository navigation
Conversation
4c94079 to
25b41bc
Compare
- Enable the Director Stage entry in the shared creation toolbar and open the stage editor automatically after creating the node. - Pin node, document, and keyframe identity across editor.save, undo, redo, and storage reload with a service-level command test. - Add a browser acceptance flow covering creation, editing, undo, redo, and reopen, runnable in en-US and zh-CN via DIRECTOR_STAGE_LOCALE. - npm test (676 passing at this commit's tree state). - .venv/bin/python -m pytest tests/test_creation_director.py. - node tests/browser/director_stage_entry.mjs plus the DIRECTOR_STAGE_LOCALE=zh-CN run, against the isolated creation_server.py fixture. Refs: ThinkFlowLab#241
25b41bc to
8528e1c
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review notes (comment only, no formal decision yet)I reviewed the diff and ran the suites myself on What I verified locallyWindows, Python 3.12, Node 24, checked out at the PR head:
The one failure in each suite is pre-existing on clean CI is green on all eight checks, including the three browser lanes, and Codex reported no findings at this same commit. What the change actually doesWorth stating for the record, because the diff is much smaller than the file count suggests: the machinery already landed on
The part I looked at hardestThe auto-open uses if (historyRef.current.present.id !== current.id) return;
const created = historyRef.current.present.nodes.find((candidate) => candidate.id === node.id);
if (created) void openEditor(created);That is the right shape. It waits for the commit to be present, bails out if the document moved on (so an undo or a reload between create and frame cannot open a stale node), and re-reads the node from history instead of closing over the pre-commit object. The Two things for whoever merges
Why this is not an approval yetNothing in the code needs to change. I am simply holding the formal decision until the landing order of the #241 stack (#328 → #329 → #330 → #331) is settled, so the approval is not stranded on a branch that gets restacked. Ping me when that order is agreed, or if you would rather have the approval now regardless — either is fine by me. |
Please link this PR to #262 and claim the milestone there@MrDongsls this PR currently declares only Why #262 matters here. #262 is the Q4 canvas/timeline roadmap, and its "By December 31 · P1" milestone explicitly lists:
That is exactly this stack — #328 (creation entry), #329 (import), #330 (output assets), #331 (agent publishing). #241 is the right feature issue, but it does not tell the roadmap where the milestone stands. Both links are useful: #241 covers the feature design, #262 covers delivery. Two asks
What would make the claim comment useful
No code change is being requested by this comment — only the links and the claim. |
…b#329 (feat/stage-import-editor) Fold the Director Stage creation entry slice into the import PR so both slices are reviewed and landed as one change, per review feedback on ThinkFlowLab#329.
Refs #241
Refs #262
Summary
The creation menu and tool rail can create a Director Stage node, the editor opens right after creation, and the stage document persists through apply, close, and reopen. This is slice 1 of 4 delivering #241; the import pipeline, output assets, and agent publishing land on top in #329, #330 and #331.
src/canvas/creationTools.tsregisters theexternalDirector Stage entry;src/canvas/workspace/useWorkspaceInteraction.tsxopens the editing session for the new node.externalnode's editor binding projects to adirectoreditor document, covered by backend contract tests intests/test_creation_director.py.tests/browser/director_stage_entry.mjscovers create, edit, apply, reopen, undo and redo in bothen-USandzh-CN.Linked issue
Labels
type:feat,area:canvasTest plan
npx tsc --noEmitclean;npm test676/676;npm run check:i18n0 problems;.venv/bin/python -m pytest tests/test_creation_director.py1 passed;node tests/browser/director_stage_entry.mjsandDIRECTOR_STAGE_LOCALE=zh-CN node tests/browser/director_stage_entry.mjsboth pass (checks: shared creation toolbar entry, automatic editor opening, external node projects to director document, keyframes persist and reopen, undo and redo preserve identities, no page errors).Evidence that it works
tests/browser/creation_server.pybackend:Provider verification
Bilingual UI