Repository navigation
[feat] web: import self-contained 3D models into the stage #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MrDongsls
wants to merge
28
commits into
ThinkFlowLab:main
Choose a base branch
from
MrDongsls:feat/stage-import-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
8528e1c
[feat] web: create Director Stage nodes that save and reopen
MrDongsls 11e8b2a
[feat] contracts: imported stage assets pin registered file identity
MrDongsls b87df1b
[feat] web: import GLB and self-contained GLTF into the Director Stage
MrDongsls 2e4f5e2
[feat] contracts: probe stage model bytes and pin self-contained imports
MrDongsls f1d1db4
[feat] web: probe stage imports in the browser and drive imported ani…
MrDongsls 282d4fd
[bugfix] web: rename the stage export snapshot that shadowed the stil…
MrDongsls 879b45a
[bugfix] web: restore the rest pose when leaving an imported motion clip
MrDongsls b8ba4bf
[bugfix] web: report corrupt GLB JSON instead of claiming external re…
MrDongsls 0eff527
[bugfix] web: keep stage upload titles valid for freely named objects
MrDongsls 9300d9b
[bugfix] contracts: bound stage model probing to the import byte limit
MrDongsls 5d35292
[bugfix] web: share one in-flight stage asset load across effect runs
MrDongsls 1fcf15e
[bugfix] contracts: verify stage animation metadata against pinned bytes
MrDongsls 4c5eb6d
[bugfix] web: reject stage JSON imports that pin foreign project assets
MrDongsls 94b454b
[test] stage: cover truncated imports and unavailable pinned media
MrDongsls b8299f4
[bugfix] contracts: deliver stage object validation errors bilingually
MrDongsls d616107
[bugfix] contracts: deliver pinned-reference rejection bilingually an…
MrDongsls c124800
[bugfix] web: reject compressed stage models and localize import boun…
MrDongsls 92dbe1e
[bugfix] web: own stage numeric text, playhead addressing, and camera…
MrDongsls 3e7188d
[feat] web: region-scoped stage scrolling with a centered frame
MrDongsls 2b2da9e
[test] ci: run the director stage entry check in both locales
MrDongsls bc1f5a5
[bugfix] web: wait for saved imports before exporting stage JSON
MrDongsls e0ef6a2
[test] ci: run the director stage entry check in both locales
MrDongsls e5abf7a
[test] ci: promote the director stage entry check to the gate lane
MrDongsls ad67e44
[test] browser: keep the stage undo lookup unique while the editor cl…
MrDongsls d4fde9f
[test] ci: promote the director stage entry check to the gate lane
MrDongsls fbec53a
Merge PR #328 (feat/stage-node-entry) into PR #329 (feat/stage-import…
MrDongsls 79fa68f
[bugfix] contracts: keep stored fingerprints stable for stage fields
MrDongsls 16ff4a4
[test] contracts: end the creation fixture with a newline
MrDongsls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For HTTP
editor.create/editor.saverejections caused by incompatible assets or animation metadata,creation_publicationassigns these validation failures the genericinvalid_inputcode.localized_receiptconsequently replaces the stage-specific reason with generic request text foren-US, while returning the full English/Chinese concatenation forzh-CN. English callers lose the actionable reason and Chinese callers receive mixed-language text, contrary toAGENTS.md's requirement that “neither leaks the other language.” Add dedicated issue codes and per-locale presentation lookups instead of concatenating translations in these exceptions.AGENTS.md reference: AGENTS.md:L86-L89
Useful? React with 👍 / 👎.