Repository navigation
feat: support exact 17k+5 frame durations for vLLM-Omni - #334
Merged
FayeSpica merged 7 commits intoNov 16, 2026
Merged
Conversation
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
FayeSpica
marked this pull request as ready for review
November 15, 2026 06:01
FayeSpica
requested review from
hsliuustc0106 and
princepride
as code owners
November 15, 2026 06:01
github-actions
Bot
requested review from
Probiotics5333,
allendyu and
nikiwang-125
November 15, 2026 06:01
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
hsliuustc0106
left a comment
Contributor
There was a problem hiding this comment.
Review: Approve with follow-ups
整体设计正确、CI 全绿(head 31ff8a1):duration_matches 单一判定前后端同步、InputRules.fractionalDuration 经 exclude_if 序列化、H3 走 h3_frames 出 num_frames。以下按 file:symbol 逐条标注,从「先确认」到 Nit 排列:
- P1 先确认范围:fractionalDuration 对所有 vllm_omni 视频置真(非仅 H3)。
- P2 需验证:FastH3 小数路径未端到端验证,form['seconds'] 对 fast 是死代码。
- P3 边界:接受区间与 H3 可达帧不对齐。
- P3/Nit:时长控件 UI 与全精度序列化小问题。
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support fractional video durations for vLLM-Omni H3 and FastH3 adapters, with integer slider steps and decimal typing for users and agents. Show the aligned frame count and actual expected duration beside the input.
num_framesandfpsfor H3/FastH3, withoutsecondsor a duration alias. The server owns17k+5alignment:107/24seconds requests exactly 107 frames; 15 seconds requests 360 frames and aligns to 362.seconds. Explicit H3/FastH3 adapter aliases retain fractional support; other protocols keep their declared rules.Test plan
python -m pytest tests/test_video_resolution.py tests/test_creation_parameters.py tests/test_vllm_omni_h3.py tests/test_fasth3_inputs.py tests/test_self_hosted.py tests/test_self_hosted_queue.py tests/test_video_capabilities.py -qTest result
At
4561e40d:num_framesandfps, withoutsecondsor a duration alias. Added 4.33-second and107/24-second cases; recovery still makes no second submission. Coverage also includes adapter gating, duration persistence and original-byte preservation.4b1f5dceand pass with this change: a 4.33-second request retains the returned video longer than 4.4 seconds during normal download and recovery.Evidence that it works
A real FastH3 generation at
4b1f5dceused the current canvas: a 4.33-second request sentnum_frames=104andfps=24, withoutsecondsor a duration alias. The server returned 107 frames at 24 fps (4.458333 seconds); the original file decoded successfully. That run exposed the previous automatic trim to 104 frames, which this change removes. Original-byte preservation at the new head is verified with local-media regression tests; no new real-provider generation was run after removal.Earlier UI validation
At
4b1f5dce, 820 frontend tests, build, i18n and contract checks passed. Browser checks covered integer dragging, decimal typing (including8.), persistence, both UI languages and generic video choices. The current change modifies backend result handling and architecture documentation.Earlier input/persistence screenshots from
31ff8a16(before the aligned-output preview was added):