Repository navigation
Conversation
…inkFlowLab#348) Sent user bubbles rendered the asset name without the composer chip's .cw-chat-reference-label class, so long names wrapped and leaked out of the fixed-height chip onto the next line and the attachment toggle.
check:browser-locale treats the script as English because it does not select Chinese Playwright UI text. The fixture still switches zh-CN and en-US itself via setActiveLocale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sent user-message bubbles did not apply the composer chip's
.cw-chat-reference-labeltruncation, so a long asset name wrapped inside a fixed 1.5em chip and spilled onto the next line and the attachment toggle.titleand the existingassistant.reference.chipaccessible name..cw-chat-referencealso setsoverflow: hiddenso a missing label class cannot leak text again.Linked issue
Fixes #348Labels
type:bug,area:agentChange
The composer already created a
.cw-chat-reference-label(min-width: 0; overflow: hidden; text-overflow: ellipsis; white-space: nowrap).AssistantPanelrendered<span>{part.name}</span>without that class. Combined withwhite-space: pre-wrapon the bubble text and a chip height of 1.5em with no clipping, an 84-character Chinese name wrapped and covered adjacent content — matching the report on #348.ChatReferenceChipis the sent-bubble path. Display names still go throughassetDisplayName(same as the composer; it only strips a repeated extension). No new copy was added. Short names, icon-only chips, and composer truncation are unchanged.Test plan
Local
Linux, Node 24.22.1, Chromium 1248, Vite
http://127.0.0.1:5579. Isolated fixture only; no user project and no provider credentials.white-space: pre-wrap, 6 overflow rects,overlapToggle: 1094with the「收起素材」row, emptytitle).PLAYWRIGHT_MODULE=... CHROMIUM_PATH=... BROWSER=chromium CREATION_WEB_URL=http://127.0.0.1:5579 node tests/browser/assistant_reference_overflow.mjstests/browser/assistant_activity.mjs(same Vite fixture style) passed.npx tsc --noEmitpassed.npm run check:i18n— 3033 keys, 0 problems.npm run check:browser-manifest— 80 entries, gate=24.npm test— 831 passed, 1 failed:tests/browserHost.test.ts("installed server env removes source imports…") expectsshutil.which('node')to be null when PATH is onlydirname(process.execPath), but this box still finds/usr/bin/node. The test file is unchanged frommain(729b49bc); not caused by this PR.npm run build(tsc --noEmit && vite build) passed.Left to CI
Release checks (static, python, frontend, browser isolated/voice/assistant). The new script is in the
gatelane oftests/browser/manifest.jsonandscripts/run-browser-suite.mjs. It needs the Vite dev server (notvite preview).Evidence that it works
ChatReferenceChipfixture (screenshots below). The issue's original overlap screenshot is the before; after the fix the long name stays on one line with an ellipsis, and「收起素材」/ following text stay unobstructed in dark 420px, dark 280px, and light 420px. Hovertitleis asserted in the test; the native tooltip does not always paint in headless screenshots.Provider verification
No live or paid provider calls. The fixture mounts production UI components through Vite with in-memory names only.
Bilingual UI
No new strings. The chip reuses
assistant.reference.chip. The browser check runs zh-CN and en-US.Not verified / out of scope
AssistantPanelnow renders).