Repository navigation
[test] canvas: correct duration warning boundary checks - #391
Merged
wangtiance merged 1 commit intoNov 17, 2026
Merged
Conversation
## summary - Treat End as a valid maximum in the control theme journey. - Exercise warning styling with genuinely out-of-range input. - Cover endpoint selection, clamping and warning clearing in both interface languages for FastH3 and H3. Fixes: ThinkFlowLab#378
wangtiance
requested review from
hsliuustc0106 and
princepride
as code owners
November 17, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The control-theme journey pressed End (a valid model maximum) and then waited for a warning that correctly does not appear. Assert the valid endpoint has no warning, then enter a genuinely out-of-range value to verify light-theme warning styling and clamping. Add Home/End, lower/upper overflow, and immediate warning clearing coverage for FastH3/H3 in both interface languages. Production behavior is unchanged.
Linked issue
Fixes #378
Labels
Test plan
Local validation on Windows, Chrome 157 and Node 26.13.0, using isolated creation API + Vite:
Left to CI: Release checks and Ubuntu 22.04 Nightly extended browser lane. The full Python suite and production build were not run locally for this test-only change.
Evidence that it works
N/A for product media: tests only, with no user-visible product changes. The original journey failed at the reported warning wait; both modified complete journeys passed with no page errors. A local screenshot confirmed the warning remains readable in the light theme.
Provider verification
No real-provider calls. The journeys use isolated model fixtures and real browser/media operations; no generation was submitted.
Bilingual UI
No user-facing copy changed. New duration boundary assertions ran in both zh-CN and en-US.