Skip to content

[test] canvas: correct duration warning boundary checks - #391

Merged
wangtiance merged 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/fix-378-duration-theme-test
Nov 17, 2026
Merged

wangtiance merged 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/fix-378-duration-theme-test

Conversation

@wangtiance

Copy link
Copy Markdown
Collaborator

Summary

The control-theme journey pressed End (a valid model maximum) and then waited for a warning that correctly does not appear. Assert the valid endpoint has no warning, then enter a genuinely out-of-range value to verify light-theme warning styling and clamping. Add Home/End, lower/upper overflow, and immediate warning clearing coverage for FastH3/H3 in both interface languages. Production behavior is unchanged.

Linked issue

Fixes #378

Labels

  • type:ci, area:ci

Test plan

Local validation on Windows, Chrome 157 and Node 26.13.0, using isolated creation API + Vite:

  • Reproduced the original control_theme.mjs timeout at line 310 waiting for .cw-duration-notice before the change.
  • Passed node tests/browser/control_theme.mjs after the change, including light/dark theme checks; inspected the duration warning screenshot.
  • Passed node tests/browser/composer_duration.mjs, including zh-CN/en-US boundary regressions and persistence/reload checks.
  • Passed node --check for both changed scripts.
  • Passed npm run check:i18n, npm run check:browser-manifest, npm run check:browser-locale and git diff --check.
  • Passed python -m pre_commit run --from-ref upstream/main --to-ref HEAD using a copied Git index and temporary object directory because this environment restricts .git writes by child processes. The same configured hooks ran without exclusions. Automatic hook installation was attempted but blocked by .git/hooks permissions.

Left to CI: Release checks and Ubuntu 22.04 Nightly extended browser lane. The full Python suite and production build were not run locally for this test-only change.

Evidence that it works

N/A for product media: tests only, with no user-visible product changes. The original journey failed at the reported warning wait; both modified complete journeys passed with no page errors. A local screenshot confirmed the warning remains readable in the light theme.

Provider verification

No real-provider calls. The journeys use isolated model fixtures and real browser/media operations; no generation was submitted.

Bilingual UI

No user-facing copy changed. New duration boundary assertions ran in both zh-CN and en-US.

## summary

- Treat End as a valid maximum in the control theme journey.
- Exercise warning styling with genuinely out-of-range input.
- Cover endpoint selection, clamping and warning clearing in both
  interface languages for FastH3 and H3.

Fixes: ThinkFlowLab#378
@github-actions github-actions Bot added area:ci Continuous integration and checks type:ci Build, test and release automation labels Nov 17, 2026
@wangtiance
wangtiance merged commit c3137e9 into ThinkFlowLab:main Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Continuous integration and checks type:ci Build, test and release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] nightly: control theme test expects a duration warning at the valid maximum

1 participant