Repository navigation
Conversation
|
Corrected in place: this close was not dispatched by the Lead, and a draft PR does not occupy the owner-click queue ( Lead action: |
…ort names none (#1141) The #1137 fix stopped pairing seed 0's artifact with pooled scores and says in the note that the numbers describe the method, not one artifact; the promote steps still said 'review the artifact diff' / 'apply it'. _next_actions now takes the per-seed agreement and, when the seeds disagree, points at run.per_seed and asks for one seed's artifact to be chosen and applied explicitly. Single-seed and agreeing-seed reports keep their text.
|
The clean-host run the body's
The tip's +2 passed are exactly the two new test rows. The sorted failed/error id lists (31 each) are byte-identical between the two runs — |
|
Review (Birfy) Tip SHA: b7b4e03
|
Fixes #1141
What changed
The
#1137fix stopped pairing seed 0's artifact with pooled multi-seed scores, and its note now says the pooled numbers "describe the method, not a single artifact". The same report'snextfield still said "review the artifact diff" / "apply it as a separate, explicit step" — advice that names an artifact the report itself refuses to name._next_actions(agentdescent/pilot.py) now takes the per-seed agreement, and when the seeds produced different artifacts it returns:run.per_seedand review that diffSingle-seed and agreeing-seed promote reports keep their previous text; defer/rollback/reject steps are untouched. One
Fixedfragment.Verification at the tip
Tip SHA: b7b4e03
Ran:
d4b66cfawith only the new test rows applied:1 failed, 1 passed, 14 deselected.test_a_promoting_multi_seed_report_never_points_at_one_artifactfails onassert "review the artifact diff" not in stepswhile the report already promotes withartifact_hashandreported_seedbothNone;test_an_agreeing_multi_seed_report_keeps_its_promote_stepspasses at main, so the change cannot pass by dropping the text for everyone.tests/test_pilot.py16 passed;tests/test_pilot.py tests/test_promotion.py tests/test_trust_evidence.py tests/test_stats_eval.py→ 51 passed.python -m tools.gen_api_docs --check→docs/api.md is up to date.python -m tools.changelog_fragments check→65 changelog fragment(s) OK.Not run:
pytest -q— no clean-host green exists on this box. Same offline venv, redirectedHOME/TMPDIR(keeps the apply/backup and wheel-smoke rows passing): at the tipb7b4e03f→21 failed, 7676 passed, 61 skipped, 504 warnings in 2208.22s; at cleand4b66cfa→21 failed, 7672 passed, 63 skipped, 504 warnings in 2684.25s. The 21 failing node-ids are the identical set on both trees — 12test_sandbox_container(no Docker on this host), 6test_era_srbench, 2test_genesis_example, 1test_integrationslauncher row (stale shared venv) — all host-shaped, none from this diff. The only count deltas: this diff's two new rows (pass at the tip, absent at main) and twotest_repo_hygienerows that skip in the control run only because it was staged as a git worktree (.gitis a file there, so their checkout guard skips) and pass in this branch's fresh clone. CI's matrix atb7b4e03fis the authoritative suite.mkdocs build --strict— nodocs/ormkdocs.ymlchange.