Skip to content

docs(site): replace the chat footer with a risk notice and add follow-ups - #1144

Open
HugoXK wants to merge 1 commit into
mainfrom
agent/site-chat-footer
Open

HugoXK wants to merge 1 commit into
mainfrom
agent/site-chat-footer

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Refs #1126 (follow-up to the merged #1127).

What changed

  • Footer: the chat panel now ends with the risk notice — DeepWiki is third-party and model-generated; verify load-bearing answers against the source — instead of MCP setup. MCP setup belongs with the integration docs, so it moved behind the header info icon and the /deepwiki/ page.
  • Follow-ups: the last two question/answer turns are included as context in the next question, so a follow-up like "and where is that implemented?" works; New chat clears the history.
  • Stop / Retry: the typing state has a Stop action (AbortController); stopped or failed questions get a Retry action.
  • Mobile: the composer respects env(safe-area-inset-bottom) and the log uses overscroll-behavior: contain.
  • Only docs/assets/deepwiki.js and docs/assets/deepwiki.css change; no engine or page changes.

Verification at the tip

Tip SHA: 4836063

Ran:

  • mkdocs build --clean --strict (social disabled locally) -> pass
  • python tests/test_site_navigation.py site -> 148 rendered pages pass
  • node --check docs/assets/deepwiki.js -> pass

Not run:

  • social cards and Playwright layout — the docs workflow runs both on this PR
  • full pytest -q — the tests workflow runs it on this PR

Merge to main deploys https://thinkflowlab.github.io/agentdescent/.

The chat footer now says what a reader needs (third-party, model-generated, verify the source) instead of "MCP setup"; MCP lives behind the header info icon and the /deepwiki/ page. Follow-ups include the last two Q/A turns, the typing state can be stopped, failures can be retried, and the composer respects the mobile safe area.
@HugoXK HugoXK added area:docs Documentation site (docs/, mkdocs.yml) and README documentation Improvements or additions to documentation labels Nov 17, 2026
@github-actions github-actions Bot added risk:T1 Risk tier T1 (tests, examples, changelog.d), set by the controller from the diff agent-pr Pull request opened by an agent labels Nov 17, 2026
@Birfy

Birfy commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Review (Birfy)

Tip SHA: 4836063
Ran:

  • .github/scripts/risk_gate.py --pr 1144 → T1 (84 lines / 2 files)
  • node --check docs/assets/deepwiki.js → pass
  • live check: https://thinkflowlab.github.io/deepwiki/ → 404; https://thinkflowlab.github.io/agentdescent/deepwiki/ → 200
  • CI at this tip → required checks green (build, test 3.9–3.13); otel-wire SUCCESS; deploy skipped; risk tier and reviewed tip are report-only SUCCESS
    Not run:
  • mkdocs build --strict locally — the CI build job is green at this tip
  • Playwright layout locally — the docs workflow ran it on this PR
  • Full offline suite locally — the CI test matrix is the line
  • Ark real-model run — no model path changed
    Findings:
  • The new header info link and the footer "Caveats" link both use href="/deepwiki/". On the production site (site_url: https://thinkflowlab.github.io/agentdescent/) that path 404s; the real page is /agentdescent/deepwiki/. Local and CI mkdocs serve at /, so Playwright would not catch this. The same href was already in the footer on main; this PR adds a second copy in the header and the stated goal is to send readers to that page (MCP setup / caveats). Please derive the site base so both links work on GitHub Pages and locally — for example from the loaded assets/deepwiki.js script src — rather than hard-coding a root-absolute /deepwiki/.
    Verdict: FAIL

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-pr Pull request opened by an agent area:docs Documentation site (docs/, mkdocs.yml) and README documentation Improvements or additions to documentation risk:T1 Risk tier T1 (tests, examples, changelog.d), set by the controller from the diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants