Repository navigation
fix(settings): bring a provider card's Remove up to date after a save - #125
Merged
Merged
Conversation
Remove and its confirmation are drawn only for a provider with a saved value. A save fetches the page again but copied only the card's state and test result, so a built-in provider's first key showed no Remove until a reload, and a cleared one kept a stale Remove. The saved event now carries the fresh card's Remove button and its question, and the card takes them whenever their presence changes. The click and Escape handlers are delegated, so the new elements ask first as before. Closes ThinkFlowLab#118
harenome
marked this pull request as ready for review
November 13, 2026 16:40
aitianshi
added a commit
that referenced
this pull request
Nov 16, 2026
No linked issue: the owner asked for v0.1.1 as a release, so that the Hugging Face endpoint setting (#129) reaches PyPI. ## What Prepares v0.1.1. The version becomes `0.1.1`, and `docs/releases/v0.1.1.md` gives the highlights since v0.1.0, a Contributors section, the full changelog of every pull request in `v0.1.0..main` (#114, #117, #120, #122, #125, #127, #129, #132, #137, and #135 among the test and CI changes) and the installation notes, in the shape of v0.1.0's. Install examples, the release guide, the docs' release-notes link and menu, and the workflows' default tags name 0.1.1. The release tooling already accepts final `vX.Y.Z` tags and does not change. ## Touches CI and skills (the release and publish workflows' default tags) · docs and site ## Verified - Backend suite (`python3 app/tests/parallel.py`): 1991 tests in 116 modules, OK. Route suite: 428 tests in 41 modules, OK. - `catalogue_docs.py --write` and `diagrams.py --write` left no change. - `python3 app/packaging/release.py build --tag v0.1.1` built and verified `nullius_eval-0.1.1-py3-none-any.whl`, `nullius_eval-0.1.1.tar.gz` and `SHA256SUMS`; `release.py verify --tag v0.1.1` and `verify.py` on the wheel passed, including the installed-tool and profile-preservation checks. - The workflows have not run; they run only by hand on `main`. ## Risk Version strings and docs only. A wrong default tag in a workflow is an input the person running it can change, and `release.py` refuses a tag that does not match `pyproject.toml` or has no notes. Nothing is tagged, drafted or published by this change. Undo with a revert.
Closed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
What
Settings → Model providers shows Remove and its question only for a provider with a saved value. After a save, the page copied only the state and the test result of each card from the fresh page. Thus the first key of a built-in provider showed no Remove until a reload, and a cleared provider kept a stale Remove.
The
nullius-settings-savedevent now also carries the Remove button and the question of each fresh card. When their presence changes, the card replaces its own with them. The click and Escape handlers are on the section, so the new Remove asks first, as before.Touches
templates and static (
app/static/settings/autosave.js,app/static/settings/providers.js) · routes (app/ui_tests/test_settings_page.py)Before and after
Settings → Model providers, 1280 px, light. Add a provider → OpenAI, type a key, then Done. No reload.
Remove on the same card asks first (after only):
Verified
On this branch, in a throwaway container with Node 24:
python3 app/tests/parallel.py: 1934 tests in 113 modules, OK.python3 app/tests/parallel.py app/ui_tests: 402 tests in 39 modules, OK.test_a_save_brings_remove_to_a_card_and_takes_it_awayrunsproviders.jsin Node on the rendered pages. It checks a first key, Remove and its question, Keep it, Yes, and a cleared key. With theproviders.jsofmain, it fails: the card has no Remove after the save.Browser check, Chromium (Playwright 1.49.1), 1280 px, light and dark, with a fixture key:
main: no Remove after Done. Remove appears after a reload.Risk
Low. The change is only in the scripts of the Settings page. If it is wrong, a card can show a Remove that does not match its saved state until a reload. The server still decides what Remove clears. A revert undoes it.