Repository navigation
fix(runs): draw a launch's controls whatever their state - #127
Merged
harenome merged 1 commit intoNov 13, 2026
Merged
Conversation
A launch card hid its nop and oracle rows, and its task-check line, as soon as one of its agents' jobs was written by the Nullius standard: the template read "the launch has a runner" as "its checks are arms". A standard plan's controls not written yet were also drawn as agent rows, since only a Harbor plan was asked for its controls. Classify a job as a control by what it is (its config, else the run's plan, Harbor or standard), then draw its state. The task-check line says which control ended before it checked every task: stopped, failed, not run, or fewer trials than planned. A control whose run ended no longer reads "running" from a result record a Stop left.
harenome
marked this pull request as ready for review
November 13, 2026 17:43
aitianshi
added a commit
that referenced
this pull request
Nov 16, 2026
No linked issue: the owner asked for v0.1.1 as a release, so that the Hugging Face endpoint setting (#129) reaches PyPI. ## What Prepares v0.1.1. The version becomes `0.1.1`, and `docs/releases/v0.1.1.md` gives the highlights since v0.1.0, a Contributors section, the full changelog of every pull request in `v0.1.0..main` (#114, #117, #120, #122, #125, #127, #129, #132, #137, and #135 among the test and CI changes) and the installation notes, in the shape of v0.1.0's. Install examples, the release guide, the docs' release-notes link and menu, and the workflows' default tags name 0.1.1. The release tooling already accepts final `vX.Y.Z` tags and does not change. ## Touches CI and skills (the release and publish workflows' default tags) · docs and site ## Verified - Backend suite (`python3 app/tests/parallel.py`): 1991 tests in 116 modules, OK. Route suite: 428 tests in 41 modules, OK. - `catalogue_docs.py --write` and `diagrams.py --write` left no change. - `python3 app/packaging/release.py build --tag v0.1.1` built and verified `nullius_eval-0.1.1-py3-none-any.whl`, `nullius_eval-0.1.1.tar.gz` and `SHA256SUMS`; `release.py verify --tag v0.1.1` and `verify.py` on the wheel passed, including the installed-tool and profile-preservation checks. - The workflows have not run; they run only by hand on `main`. ## Risk Version strings and docs only. A wrong default tag in a workflow is an input the person running it can change, and `release.py` refuses a tag that does not match `pyproject.toml` or has no notes. Nothing is tagged, drafted or published by this change. Undo with a revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126
What
A launch card now draws every job that it counts. A job is classified as a control by what it is: its config (
Job.kind), or the run's plan when the job is not written yet, for Harbor and standard plans. Its state is then drawn like an agent row's. Before, the template hid control rows and the task-check line when the launch's first agent job had a runner, which is true for every standard job. Also, a standard plan's controls that were not written yet were drawn as agent rows.The task-check line now names a control that ended before it checked every task: "Task checks incomplete: nop stopped, oracle not run." Incomplete means stopped, failed, refused, not run, or fewer trials than planned. A control whose run ended no longer reads "running" from a result record that a Stop left. Controls stay unranked and are not offered to Compare. Shard grouping does not change.
Touches
routes · templates and static
Before and after
A standard launch stopped during its nop (2 of 4 tasks, no job-level
result.json); oracle not run. Light theme, 1280 px.Before: "4 runs", 3 rows, the oracle as an agent row, no nop row, no task-check line. After: 4 rows, the nop "stopped" with its 2 tasks, the oracle "not run", and the line "Task checks incomplete: nop stopped, oracle not run."
Verified
test_a_standard_launch_draws_its_controls_whatever_their_state: a standard launch with its controls running/queued, stopped/not run, finished/failed, finished but cut short, and complete. For each, the header count equals the drawn rows, the control rows have the expected states, the task-check line is as expected, and no control is offered to Compare. It fails onmain.test_controls_apart: the oracle fixture planned 5 tasks and ran 3. It now plans 3, so it still tests a complete oracle; with 5 it now reads "oracle ran 3 of 5".python3 app/tests/parallel.py(1978 tests) and route suitepython3 app/tests/parallel.py app/ui_tests(421 tests) pass in a clean container.Risk
Low. The change is in the Runs page view and its template. If it is wrong, a launch shows a control row or a task-check line that it should not show, or the line says "incomplete" for a control that is complete. A runner's arm named
oracleis still an agent (Job.kind), and a standard plan names its setupsoriginalormodel, nevernopororacle. Revert the commit to undo.