Repository navigation
fix(web): list the Nullius run tag before Harbor on benchmark cards - #141
Merged
Merged
Conversation
🔴 PR judge · 4 of 6 yes · #141, no linked issue
Checks the script runs itself, 4 of 4 pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A benchmark card on the Benchmarks page listed its run tags as Harbor then Nullius. It now lists Nullius first, the order the benchmark's own page and the filter buttons already use.
Touches
Templates and static:
app/templates/catalogue/benchmarks.html.Before and after
Before: τ³-bench card showed
HarborNullius. After:NulliusHarbor.Verified
python app/tests/parallel.py app/ui_tests, 431 tests OK./benchmarkswith a temporary profile: all three cards with both tags liststandardbeforeharbor.Risk
Display order only. Undone by a revert.