Repository navigation
fix(web): reopen the open workspace after a restart, not the run's - #158
Merged
harenome merged 2 commits intoNov 16, 2026
Merged
Conversation
At start-up, a run picked up again went back into its workspace and also opened it when no workspace was open. A restart without arguments thus opened the workspace of the run, not the first steps, and marked it as the workspace opened last. Add the job to its workspace and leave it closed.
A start with no job path given showed the first steps, and the user had to open the workspace again. Reopen the workspace opened last. Job paths given at start-up still decide. Close marks the workspace as closed, so a restart leaves it closed. Opening it again clears the mark. Reopen before restored runs go back into their workspaces. A run whose record names no workspace now goes into the reopened one.
3 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
What
A restart without job paths showed the first steps of the Runs page, or the workspace of a run that it picked up again. Now it reopens the workspace that was open.
shared.adopt_roots(..., into=name)adds the job of a run picked up again to its workspace and does not open that workspace. Before, it opened the workspace when none was open.mainreopens the workspace opened last (workspace.last_open, the first ofworkspace.list_all, which sorts byopened). This occurs before the app picks up runs again.closedin itsworkspace.json. A restart then opens no workspace. Opening the workspace again clears the mark.Touches
backend · routes · docs and site
Verified
On
main(b11083b) and on this branch, each in a clean rootless container (python:3.12, a temporaryNULLIUS_HOME).The real app: workspace
alphaover/r/a, workspacebravoover/r/b, a run with one partsleep 300started frombravothroughPOST /run. Then the action in the first column, the app stops, and the app starts again.mainalphaopen, the run goes onbravoopenalphaopen, the run's job inbravoalphaopen, no runalphaopenbravoopenbravobravodeleted, no runalphaopen (opened last)alphaopen, no run/r/bbravoopenbravoopenalphaopen,/r/aremoved, no runalphaopen, as Open doesalphaopen,WORKSPACES_DIRset, no runalphaopen, fromWORKSPACES_DIRTests:
ReopenAtStartandResumeIntoWorkspaceinapp/ui_tests/test_run_routes.py: 9 tests. With these tests onmain, 5 fail. On this branch, all pass.Lifecycle.test_last_open_is_the_latest_unless_the_user_closed_itinapp/tests/test_workspace.py.python3 app/tests/parallel.py: 2046 tests in 119 modules, OK.python3 app/tests/parallel.py app/ui_tests: 353 tests in 42 modules, OK.Risk
The start-up changes for every user: a start without job paths now opens the workspace opened last, unless the user closed it. At start-up, the app converts the foreign roots of that workspace before it serves, as Open does. If the change is wrong, the wrong workspace opens. The user can open another one or close it. No data moves or is deleted. A workspace saved by this version has a
closedfield, which older versions ignore. A revert undoes it.