Repository navigation
feat(rooms): several agents can answer on the side at once, and one review call can ask a council - #948
Merged
Conversation
…eview call can ask a council A room ran one side answer at a time, so a council of reviewers had to go one after another, and each review counted against the agents' request limit, which refused a second round. - A thread's live side answers are a list (sideTurns), up to three, one per agent; sideTurn stays as the first for older clients. Every lookup goes through @threadlines/shared/sideTurns, by id, in the decider, the request decisions, the reactor, ingestion, both projections and the web store. - projection_threads.side_turn holds a JSON array; a row with the old single object reads as a list of one. No migration. - room_review takes agents (two or three): the changes are captured once, each agent gets its own request sharing a batchId, and they run side by side; the result lists each review. A batch counts once toward the request limit (batchesSinceUser), however its members settle. - Busy rules are per agent plus the cap, including a guest brought back by an invite. A held message waits only for its own agent's answer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 16, 2026
…fewer than three answer
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A room ran one side answer at a time. A "council" of reviewers (say Sol, Opus and Grok on the same diff) had to go one after another, and every review counted against the agents' three requests per user message, so a second round was refused.
What changes
sideTurns, oldest first;sideTurnstays as the first entry for older clients. Everything reads them through@threadlines/shared/sideTurns, by id: the decider, the request decisions, the reactor (start, re-checks, interrupt, timeout, caller-turn-ended, session stop and restart loop over all), runtime ingestion's late-output guard, both projections and the web store. Events are unchanged: started appends, running and interrupt-requested update by id, settled removes by id.projection_threads.side_turnnow holds a JSON array (null when none). A row holding the old single object reads as a list of one, so nothing is rewritten.room_reviewtakesagents(two or three) instead ofagent. The changes are captured once, each agent gets its own request sharing abatchId, they run side by side, and the result lists each review inreviews. An identical retry joins the running call; a call dropped during capture sends nothing.ROOM_AGENT_REQUEST_LIMIT, remembered inbatchesSinceUser(cleared when the user writes), so a member is never re-counted or refused however its siblings settle. Requests outside the batch still wait for the user.Tradeoffs
sideTurn. Others read as stopped until they settle; the thread's Stop still stops them. Same skew we accepted for attachments.room_review's description and itsagentsoption) and 32 bytes up front (room_askno longer says one answer at a time).agentContextBudget.jsonis updated; it's what agents need to know to run a council.How it was checked
vp fmt,vp lint,vp run typecheck, the full unit suite (vp run test) and the full web browser suite pass. A desktop menu test failed once on this checkout's missing Electron install and passed on rerun.Not checked: a live council with real agents in the running app.