Repository navigation
fix(release): WinGet token scope, and no pile-up of new-package requests - #951
Merged
Merged
Conversation
The 0.10.0 and 0.10.1 WinGet runs failed with a CreateRef permission error: winget-pkgs changed its own workflow files, and GitHub refuses to push those to the fork without the workflow scope. Will added the scope and the 0.10.1 run then opened microsoft/winget-pkgs#481445.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Until a moderator approves the first New package pull request, every stable release opened another one, each waiting weeks in the same queue. A new check job looks for the package in winget-pkgs and for an open New package request; while one waits, the submit job is skipped with a notice. Dry runs still run.
Anyone can open a winget-pkgs pull request titled "New package: Threadlines.Threadlines". Limit the waiting check to requests authored by the WINGET_TOKEN account so a stranger's can't block our submissions (Vercel Security Review finding 21).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinGet runs for 0.10.0 and 0.10.1 failed with a CreateRef permission error: winget-pkgs changed its own workflow files, and GitHub won't push those to our fork without the
workflowscope. The token now has it, and the 0.10.1 rerun opened microsoft/winget-pkgs#481445. The workflow note anddocs/release.mdnow say the token needspublic_repoandworkflow.New apps wait about eight weeks for a moderator, and until the first is approved every stable release would open another "New package" request. A new
checkjob looks for Threadlines in winget-pkgs and for an open New package request. While one waits,submitis skipped with a notice, so the oldest request keeps our place in line. Once listed, releases go out as normal updates, which merge within hours. Dry runs still run. The docs say to send the newest version by hand on approval day.