Skip to content

test(web): the panel-corner test reads the layer tree once fades have ended - #955

Merged
badcuban merged 1 commit into
mainfrom
test-panel-corner-fades
Nov 16, 2026
Merged

badcuban merged 1 commit into
mainfrom
test-panel-corner-fades

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

The panel-corner test (ChatView.desktop-window, "rounds the panel's corner without a mask layer the size of the panel") still failed about one run in two when the ChatView browser tests ran together, on main and with #952's longer wait.

Why

CDP's layer report at the moment of failure showed the chat's content lifted onto a 651×4144 layer with no element. Its compositing reason was Overlap, and beside it was a 55×25 layer whose reason was ActiveOpacityAnimation. Something in the chat was mid-fade. While an element fades, Chrome moves the content it overlaps onto layers of its own and folds them back when the fade ends. The test read the tree mid-fade and took that layer for the rounded clip's mask. The mask #932 removed is permanent; this one is not.

Fix

After the chat's scroller is its own layer, the test waits for every animation that ends to finish (a looping spinner never does), then reads a fresh layer report and checks that one.

Checked

  • The 15 ChatView browser test files run together: 6/6 green. Before, about 1 failure every 2 runs.
  • The test still catches the real bug: with the old rounded clip injected (border-top-left-radius plus overflow: hidden on the panel), it fails with 4 mask layers.
  • vp fmt, vp lint, typecheck.

… ended

While an element fades (a pill or button appearing in the chat), the browser lifts the content it overlaps onto layers of their own until the fade ends. On a busy runner the test sometimes read the tree mid-fade and took the chat content's overlap layer (651x4144, reason Overlap, beside an ActiveOpacityAnimation layer) for the rounded clip's mask. It now waits for animations that end, then reads a fresh report. With the old rounded clip restored the test still fails (4 mask layers).
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 16, 2026 10:23am UTC

Request Review

@badcuban
badcuban enabled auto-merge November 16, 2026 10:23
@badcuban
badcuban added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 1b273e4 Nov 16, 2026
24 checks passed
@badcuban
badcuban deleted the test-panel-corner-fades branch November 16, 2026 10:35

This branch was previously deployed

1 inactive deployment
Preview — 269bab73 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant