Repository navigation
test(web): the panel-corner test reads the layer tree once fades have ended - #955
Merged
Merged
Conversation
… ended While an element fades (a pill or button appearing in the chat), the browser lifts the content it overlaps onto layers of their own until the fade ends. On a busy runner the test sometimes read the tree mid-fade and took the chat content's overlap layer (651x4144, reason Overlap, beside an ActiveOpacityAnimation layer) for the rounded clip's mask. It now waits for animations that end, then reads a fresh report. With the old rounded clip restored the test still fails (4 mask layers).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel-corner test (
ChatView.desktop-window, "rounds the panel's corner without a mask layer the size of the panel") still failed about one run in two when the ChatView browser tests ran together, on main and with #952's longer wait.Why
CDP's layer report at the moment of failure showed the chat's content lifted onto a 651×4144 layer with no element. Its compositing reason was
Overlap, and beside it was a 55×25 layer whose reason wasActiveOpacityAnimation. Something in the chat was mid-fade. While an element fades, Chrome moves the content it overlaps onto layers of its own and folds them back when the fade ends. The test read the tree mid-fade and took that layer for the rounded clip's mask. The mask #932 removed is permanent; this one is not.Fix
After the chat's scroller is its own layer, the test waits for every animation that ends to finish (a looping spinner never does), then reads a fresh layer report and checks that one.
Checked
border-top-left-radiusplusoverflow: hiddenon the panel), it fails with 4 mask layers.vp fmt,vp lint, typecheck.