Repository navigation
fix(web): the background runs list keeps clear of the iPhone Duo's dock - #962
Merged
Merged
Conversation
On a phone the list of background runs spans the screen between 12px gutters, a width set in CSS from 100vw. It ignored the screen's side strips, so on the folded iPhone Duo it ran about 85px under the status dock down the right edge, hiding each run's Stop button and the count. The width now takes --safe-area-left and --safe-area-right out of the space it spans, matching the collision padding the positioner already adds for the strips. Screens without strips are unchanged; the open Duo already fit. The phone-width browser test adds an 85px strip and checks the list stops 12px short of it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the folded iPhone Duo, the list of background runs (the activity button in the chat header) ran about 85px under the status dock on the right edge, so each run's Stop button and the count were hidden. Its phone width was
100vwminus the gutters and ignored the screen's side strips.The width now subtracts
--safe-area-leftand--safe-area-right, matching the collision padding the positioner already adds for them (#913). Screens without strips are unchanged; the open Duo already fit. The phone-width browser test adds an 85px strip and checks the list stops 12px short of it (it failed before the fix, ending 73px inside the strip).